Update RocksDB default block cache size #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
matkt
approved these changes
Jul 19, 2022
|
the tests are failing because of this modification @ahamlat . it seems to need a quick update |
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
|
The unit tests are fixed. |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Update RocksDB default block cache size. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RocksDB default block cache size to mitigate a performance regression from #3985.
Signed-off-by: Ameziane H ameziane.hamlat@consensys.net
PR description
We can see in the dashboard below that we have some blocks behind with the RocksDB block cache default value 8 MB, and Besu with block cache size 128 MB is performing better (no blocks behind).
Fixed Issue(s)
#4128
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog