-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 1.2.5-SNAPSHOT #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
joshuafernandes
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AbdelStark
pushed a commit
to AbdelStark/besu
that referenced
this pull request
Sep 24, 2019
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
AbdelStark
added a commit
that referenced
this pull request
Sep 24, 2019
* Update version to 1.2.5-SNAPSHOT (#42) Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * Store db metadata file in the root data directory The database metadata file should be stored in the root data directory rather than the database subdirectory. The database subdirectory is owned by the database itself and should not be directly manipulated by the node. - first look in the data directory for the metadata file - if the metadata file is found there, process it as normal - if no metadata file is found in the root directory, look in the database subdirectory - if the file is found here, copy it to the root directory, and run based on the root directory version Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * add logs Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * create database directory if database not detected Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * change plugin API know hash Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
AbdelStark
added a commit
that referenced
this pull request
Sep 25, 2019
* Update version to 1.2.5-SNAPSHOT (#42) Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> * introduce `VirtualOperation` - add `isVirtualOperation` method to `Operation` interface: determines whether or not the operation has been virtually added to the contract code. - default implementation of `isVirtualOperation` returns `false` - create `VirtualOperation` that wraps a real `Operation` and returns `true` for `isVirtualOperation` method. - change `constructor` of `EVM` to pass a `GasCalculator` used to create the `endOfScriptStop` and `invalidOperation` fields. - change visibility of `EVM.operationAtOffset` to `package` for testing purpose. (add `VisibleForTesting` annotation) - create `EVMTest` to test `operationAtOffset` method . Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
AbdelStark
pushed a commit
to AbdelStark/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com> Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)