Better management of jemalloc presence/absence #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
check-jemalloc-presence
branch
from
f1db0d4
to
1d02f94
Compare
jflo
approved these changes
Aug 9, 2022
macfarla
approved these changes
Aug 9, 2022
ajsutton
reviewed
Aug 9, 2022
fab-10
force-pushed
the
check-jemalloc-presence
branch
from
1d02f94
to
3dba8aa
Compare
fab-10
force-pushed
the
check-jemalloc-presence
branch
2 times, most recently
from
a98aea8
to
8f212e1
Compare
ajsutton
approved these changes
Aug 19, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
check-jemalloc-presence
branch
from
18bdfc7
to
9e2faa5
Compare
Co-authored-by: Adrian Sutton <adrian@symphonious.net> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
check-jemalloc-presence
branch
from
9e2faa5
to
1e5f053
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Adrian Sutton <adrian@symphonious.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Adrian Sutton <adrian@symphonious.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Adrian Sutton <adrian@symphonious.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Adrian Sutton <adrian@symphonious.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
If jemalloc is not present, an error message is printed, but the absence of jemalloc is not a real error, so in this PR we try to understand if jemalloc is available and print messages that are easier for the user to understand, and invite him to install jemalloc to get better memory usage
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog