Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in AbstractRetryingPeerTask #4254

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Fix off-by-one error in AbstractRetryingPeerTask #4254

merged 5 commits into from
Aug 16, 2022

Commits on Aug 12, 2022

  1. Fix off-by-one error in AbstractRetryingPeerTask 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    7894998 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    68f0a98 View commit details
    Browse the repository at this point in the history

  3. Updating unit tests that were expecting maxRetries + 1 executions 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    7c65579 View commit details
    Browse the repository at this point in the history

  4. Increase by 1 current max retries to keep the same behavior 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c455ac2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Merge branch 'main' into fix-retrying-peer-task

    @fab-10
    fab-10 authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    13d37ce View commit details
    Browse the repository at this point in the history