Reduced fast-sync-min-peers default value to 2. #4285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mark-terry <mark.terry@consensys.net>
mark-terry
added
the
doc-change-required
Signed-off-by: mark-terry <mark.terry@consensys.net>
2 tasks
|
Going down to two for all networks seems dangerous imo r pre merge. I proposed in my PR to lower this number to 1 post merge and leave it at 5 pre merge. This shouldn't really be a problem for the mainnet anymore knowing that all the testnets have merged and the mainnet will soon merge. |
|
Resolved by #4298. |
rolandtyler
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mark-terry mark.terry@consensys.net
PR description
Reduces the default fast-sync minimum peers from 5 to 2 to improve syncing performance in low participation networks
Fixed Issue(s)
Partially addresses #4202
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog