Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore the tests that use tessera enclave via docker #4297

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Aug 23, 2022

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

These tests are uniformly failing since about 6 hours ago. Docker container startup error. eg

org.testcontainers.containers.ContainerLaunchException: Container startup failed
	at app//org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:345)
	at app//org.testcontainers.containers.GenericContainer.start(GenericContainer.java:326)
	at app//org.hyperledger.enclave.testutil.TesseraTestHarness.start(TesseraTestHarness.java:83)
	at app//org.hyperledger.besu.tests.acceptance.dsl.privacy.PrivacyNode.start(PrivacyNode.java:194)
	at app//org.hyperledger.besu.tests.acceptance.dsl.privacy.PrivacyCluster.startNode(PrivacyCluster.java:182)
	at app//org.hyperledger.besu.tests.acceptance.dsl.privacy.PrivacyCluster.lambda$selectAndStartBootnode$6(PrivacyCluster.java:136)
...
            org.testcontainers.containers.ContainerLaunchException: Could not create/start container

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla merged commit 98e214c into hyperledger:main Aug 23, 2022
@freemanzMrojo
Copy link
Contributor

Hi @macfarla ,

Hope you are doing well! Probably you guys have noticed this already, if so please disregard this comment, but it looks like the issue is related to the Docker image of the new Tessera release, 22.1.6.

I have changed the version of the image in my branch for the acceptance tests in TesseraTestHarness (#4282) to 22.1.5 (used to be latest) and the tests are passing (I haven't rebased yet with the latest of main including the changes of this PR).

Would it be possible to just change that version temporarily and re-enable the tests until the solution is found? I could create a PR if you want.

Thanks in advance, Miguel.

macfarla added a commit to macfarla/besu that referenced this pull request Aug 23, 2022
…dger#4297)"

This reverts commit 98e214c.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
Copy link
Contributor Author

@freemanzMrojo I did suspect the docker image change - but I looked at the Tessera version here https://github.com/hyperledger/besu/pull/4295/files and it was using 22.1.3 - turns out there's two spots where we have the docker version which is not ideal!

PR here #4303

macfarla added a commit that referenced this pull request Aug 23, 2022
* Revert "ignore the tests that use tessera enclave via docker (#4297)"

This reverts commit 98e214c.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* lock version of tessera and make public

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla deleted the ignore-tessera-tests branch August 23, 2022 23:57
@freemanzMrojo
Copy link
Contributor

Thanks @macfarla !

garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 7, 2022
* Revert "ignore the tests that use tessera enclave via docker (hyperledger#4297)"

This reverts commit 98e214c.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* lock version of tessera and make public

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 7, 2022
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* Revert "ignore the tests that use tessera enclave via docker (hyperledger#4297)"

This reverts commit 98e214c.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* lock version of tessera and make public

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants