Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Tessera version and ubuntu for xl-machine-executor #4305

Merged
merged 6 commits into from
Aug 24, 2022
Merged

update Tessera version and ubuntu for xl-machine-executor #4305

merged 6 commits into from
Aug 24, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Aug 24, 2022 •
edited
Loading

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

  • Update tessera docker image version to 22.1.6
  • Update ubuntu version on xl machine executor in Circle CI config - this update is required for the tessera 22.1.6 docker image to run

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@macfarla
latest ubuntu for xl-machine-ex
c4da768 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
tessera docker image version
70611d5 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
gradle sptls version
efe2d69 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
revert ubuntu change
cd44317 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
jframe
jframe reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@macfarla
Copy link
Contributor Author

with the ubuntu change reverted, the Tessera enclave tests fail https://app.circleci.com/pipelines/github/hyperledger/besu/16658/workflows/4205df7c-3355-4e46-b206-0dacfa2535d0/jobs/99852

org.testcontainers.containers.ContainerLaunchException: Container startup failed
	at app//org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:345)
	at app//org.testcontainers.containers.GenericContainer.start(GenericContainer.java:326)
	at app//org.hyperledger.enclave.testutil.TesseraTestHarness.start(TesseraTestHarness.java:83)

@macfarla
Revert "revert ubuntu change"
1574818 
This reverts commit cd44317.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
jframe
jframe approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 4622cf6 into hyperledger:main Aug 24, 2022
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 7, 2022
@macfarla @garyschulte
update Tessera version and ubuntu for xl-machine-executor (hyperledge…
5b4b3d3 
…r#4305)

* latest ubuntu for xl-machine-ex

* tessera docker image version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla deleted the ubuntu-ci branch November 16, 2022 04:15
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
update Tessera version and ubuntu for xl-machine-executor (hyperledge…
59cdc8b 
…r#4305)

* latest ubuntu for xl-machine-ex

* tessera docker image version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @jframe