Log imported block info post merge #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed ommers and added base fee. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
log-imported-block-info-new-payload
branch
from
907a39d
to
ed9676a
Compare
shemnon
reviewed
Aug 25, 2022
| private void logImportedBlockInfo(final Block block, final double timeInS) { | ||
| LOG.info( | ||
| String.format( | ||
| "Imported #%,d / %d tx / %,d (%01.1f%%) gas / base fee %s / (%s) in %01.3fs.", |
There was a problem hiding this comment.
Nit: could we put basefee between tx and gas? We are dropping ommers and we could just re-use the position for basefee.
There was a problem hiding this comment.
Question: is dropping peer count intentional? Does the ELs no longer gossip? If there is still gossip I think we want peer counts.
There was a problem hiding this comment.
- Moved the base fee where ommes where
- I was thinking on logging peers count in another way, but not yet sure how, so it make sense to readd them, since there is still gossip
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
shemnon
approved these changes
Aug 25, 2022
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Removed ommers and added base fee. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Removed ommers and added base fee. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Removed ommers and added base fee. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Removed ommers and added base fee. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the switch to PoS, info of the imported blocks are not more logged, this PR re-add the log when a block is imported via the NewPayload engine RPC call, and also update the info logged to remove ommers and add base fee.
Sample of the message:
Imported #12,862,033 / 5 tx / 439,018 (1.5%) gas / base fee 7 wei / (0xb1b6d51e6382a1c88b42344f53d5321ee63bec0226fae502876af55e7109f431) in 0.028s.Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog