Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing verbosity during BWS errors #4311

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Reducing verbosity during BWS errors #4311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca0716
Reducing verbosity during BWS errors
gezero Aug 25, 2022
6c2a218
Merge branch 'main' into reducing-verbosity-on-error-BWS
macfarla Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...rc/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,24 +202,24 @@ protected void processException(final Throwable throwable) {
backwardSyncException -> {
if (backwardSyncException.shouldRestart()) {
LOG.info(
"Backward sync failed ({}). Current Peers: {}. Retrying in "
+ millisBetweenRetries
+ " milliseconds...",
backwardSyncException.getMessage(),
ethContext.getEthPeers().peerCount());
return;
"Backward sync failed ({}). Current Peers: {}. Retrying in {} milliseconds...",
throwable.getMessage(),
ethContext.getEthPeers().peerCount(),
millisBetweenRetries);
} else {
debugLambda(
LOG, "Not recoverable backward sync exception {}", throwable::getMessage);
throw backwardSyncException;
}
},
() ->
LOG.warn(
"There was an uncaught exception during Backwards Sync. Retrying in "
+ millisBetweenRetries
+ " milliseconds...",
throwable));
() -> {
LOG.warn(
"Backward sync failed ({}). Current Peers: {}. Retrying in {} milliseconds...",
throwable.getMessage(),
ethContext.getEthPeers().peerCount(),
millisBetweenRetries);
LOG.debug("Exception details:", throwable);
});
}

private Optional<BackwardSyncException> extractBackwardSyncException(final Throwable throwable) {
Expand Down