Retry mechanism for block creation #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
siladu
reviewed
Sep 19, 2022
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/MiningParameters.java
Show resolved
Hide resolved
...merge/src/main/java/org/hyperledger/besu/consensus/merge/blockcreation/MergeCoordinator.java
Show resolved
Hide resolved
| retryBlockCreation(payloadIdentifier, blockCreator, remainingTime) | ||
| .thenAccept( | ||
| bestBlock -> { | ||
| final var resultBest = validateBlock(bestBlock); |
There was a problem hiding this comment.
Looks like a lot could go wrong in here, should this be included in the retry code as well?
Maybe it's not an issue if it doesn't persist to the database though.
There was a problem hiding this comment.
good point, I need to review if the lock timeout exception could be triggered here as well
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
siladu
approved these changes
Sep 19, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Retry mechanism for block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update CHANGELOG Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Always keep 1 thread active in the computation executors Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Surface StorageException when building a block for finer filtering Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Log successful block created at info Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Reformat block proposal logs Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Remove test code Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Retry block creation if there is a transient error and we still have time, to mitigate empty block issue, as describe here
#4401 (comment)
Fixed Issue(s)
mitigates #4401 when there is a
org.rocksdb.RocksDBException: TimedOut(LockTimeout)Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog