Make transaction pool limits for sender based on pool size #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
reviewed
Sep 21, 2022
Comment on lines
-1221
to
-1230
|
|
||
| @Option( | ||
| names = {"--tx-pool-future-max-by-account"}, | ||
| paramLabel = MANDATORY_INTEGER_FORMAT_HELP, | ||
| converter = PercentageConverter.class, | ||
| description = | ||
| "Maximum per account of currently unexecutable future transactions that can occupy the txpool (default: ${DEFAULT-VALUE})", | ||
| arity = "1") | ||
| private final Integer maxFutureTransactionsByAccount = | ||
| TransactionPoolConfiguration.MAX_FUTURE_TRANSACTION_BY_ACCOUNT; |
There was a problem hiding this comment.
I think we need to keep this for the moment, otherwise it is a breaking change, what we can do is to give an error if this and the new one are used together, or to say that this has no effect if the new one is used
garyschulte
force-pushed
the
feature/tx-pool-by-sender-limit-percentage
branch
3 times, most recently
from
a0f38dd
to
d3003a8
Compare
fab-10
approved these changes
Sep 22, 2022
|
Please just update the CHANGELOG |
garyschulte
force-pushed
the
feature/tx-pool-by-sender-limit-percentage
branch
from
5dbad31
to
95b24a4
Compare
|
burned in on mainnet along with 4423, 4425 |
…y sender is 5 move config into TransactionPoolOptions class Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/tx-pool-by-sender-limit-percentage
branch
from
95b24a4
to
3544300
Compare
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…er#4417) * make transaction pool limits for sender based on pool size. default by sender is 5 move config into TransactionPoolOptions class Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Limit the portion of the transaction pool that a single sender can occupy to a percentage
This PR will see the default txpool configuration restrict the number of transactions from a single sender in the pool from 64 to 5. This should decrease the cost of transaction eviction during transaction processing, and yield a transaction pool with a greater percentage of executable transactions for building a block.
Fixed Issue(s)
relates to #4401
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog