-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: log jemalloc presence at startup, not at shutdown #4738
Conversation
@ajsutton if you want to check again, since I had to move the log where it does not interfere with other options output |
What do you think about including this in ConfigurationOverviewBuilder.java ? |
Make sense, will do |
@fab-10 are you still planning on making changes to this PR? |
Converted back to draft since will continue to work on it later |
@fab-10 Do you think you can add Jemalloc log to ConfigurationOverviewBuilder.java or I can do it if you have other priorities ? |
I can do it, and I also want to report the version |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@ahamlat now if jemalloc is used then its version is printed in the overview sample output
|
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Nice, what is the output when jemalloc is not installed ? What about other Operating systems like Windows ? |
We only support jemalloc on Linux, and when it is not installed this is printed in the logs
|
I meant, what is the output at startup when Jemalloc is not installed ? (Same output as above when Jemalloc is not installed ) |
On Linux, when jemalloc is not installed, then the configuration overview does not have the jemalloc line, and in the logs there is this line at info On other OS there is nothing about jemalloc, since we only support it on Linux. |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Fixed Issue(s)
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog