Memoize transaction size and hash at the same time #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
reviewed
Dec 13, 2022
Comment on lines
58
to
+61
| if (TransactionType.FRONTIER.equals(transactionType)) { | ||
| encodeFrontier(transaction, rlpOutput); | ||
| rlpOutput.writeRaw(opaqueBytes); | ||
| } else { | ||
| rlpOutput.writeBytes(encodeOpaqueBytes(transaction)); | ||
| rlpOutput.writeBytes(opaqueBytes); |
There was a problem hiding this comment.
I scrutinized this to be sure we are not creating a regression for non-frontier transactions. LGTM
|
looks like there is a build failure for NewPooledTransactionHashesMessageProcessorTest since cacluateSize() is gone now. |
fab-10
force-pushed
the
memoize-tx-size
branch
from
78aeefd
to
0455575
Compare
Fixed |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
memoize-tx-size
branch
from
0b1deb3
to
fd5f0e6
Compare
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 22, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Since to calculate the transaction hash and size, the transaction needs to be encoded to bytes, we can cache both values at the same time, in order to avoid extra expensive encoding tasks.
Fixed Issue(s)
relates to #4724
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog