Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] move Clique tests to junit5 #4975

Merged
merged 5 commits into from
Jan 24, 2023
Merged

Conversation

macfarla
Copy link
Contributor

Migrate to Junit 5

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macfarla macfarla enabled auto-merge (squash) January 24, 2023 00:48
@macfarla macfarla merged commit 1a39e38 into hyperledger:main Jan 24, 2023
fab-10 pushed a commit to fab-10/besu that referenced this pull request Feb 1, 2023
* easy ones

* parameterized test

* refactor to avoid unnecessary stubbings

* migrate abstract class and subclasses to junit 5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla deleted the clique-junit5 branch February 3, 2023 01:26
ensi321 pushed a commit to ensi321/besu that referenced this pull request Feb 19, 2023
* easy ones

* parameterized test

* refactor to avoid unnecessary stubbings

* migrate abstract class and subclasses to junit 5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
* easy ones

* parameterized test

* refactor to avoid unnecessary stubbings

* migrate abstract class and subclasses to junit 5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* easy ones

* parameterized test

* refactor to avoid unnecessary stubbings

* migrate abstract class and subclasses to junit 5

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants