Don't cache protocol spec in block creator #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't cache the protocol spec in the block creator. With the new shanghaiTimestamp the correct spec may be a function of the timestamp not just the block number. So every time we are asked to build a block re-query the spec. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
shemnon
changed the title
siladu
reviewed
Jan 23, 2023
| @@ -154,8 +153,16 @@ protected BlockCreationResult createBlock( | |||
| boolean rewardCoinbase) { | |||
|
|
|||
| try (final MutableWorldState disposableWorldState = duplicateWorldStateAtParent()) { | |||
| final ProtocolSpec newProtocolSpec = | |||
There was a problem hiding this comment.
nit: nextProtocolSpec? nextBlockProtocolSpec?
Don't cache the protocol spec in the block creator. With the new shanghaiTimestamp the correct spec may be a function of the timestamp not just the block number. So every time we are asked to build a block re-query the spec. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* Don't cache protocol spec in block creator Don't cache the protocol spec in the block creator. With the new shanghaiTimestamp the correct spec may be a function of the timestamp not just the block number. So every time we are asked to build a block re-query the spec. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Don't cache protocol spec in block creator Don't cache the protocol spec in the block creator. With the new shanghaiTimestamp the correct spec may be a function of the timestamp not just the block number. So every time we are asked to build a block re-query the spec. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Don't cache the protocol spec in the block creator. With the new shanghaiTimestamp the correct spec may be a function of the timestamp not just the block number. So every time we are asked to build a block re-query the spec.
Signed-off-by: Danno Ferrin danno.ferrin@swirldslabs.com
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog