Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MainnetBlockBodyValidator logging #4984

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Improve MainnetBlockBodyValidator logging #4984

merged 4 commits into from
Jan 23, 2023

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jan 23, 2023 •
edited
Loading

  • Associate block number and hash with the various invalid block warnings, in the format:
    Invalid block {blockNumber} ({blockHash}): ... mismatch (expected=..., actual=...)

Instead of

WARN  | MainnetBlockBodyValidator | Invalid block: receipts root mismatch (expected=0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421, actual=0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421)

we now have

WARN  | MainnetBlockBodyValidator | Invalid block 1 (0xd2ce6fb30db1ab80b0a5c137f3c8a83d12052e5a40366eba4c15b229c6a863e6): receipts root mismatch (expected=0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421, actual=0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421)
  • Print a less obscure message when there's no error message:

Instead of

INFO  | MainnetBlockValidator | Optional.empty. Block 11 (0x8edd340dd4718e884ffe327bab2d3e3874bac2799cde83a085e5cae66d53c3b5)

we now have

INFO  | MainnetBlockValidator | Invalid block 11 (0x8edd340dd4718e884ffe327bab2d3e3874bac2799cde83a085e5cae66d53c3b5)

@siladu
Associate block number and hash with the various invalid block warnings
1f58445 
Print a less obscure message when there's no error message.
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
garyschulte
garyschulte reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just waiting on your next push

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/MainnetBlockValidator.java Outdated Show resolved Hide resolved
...reum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetBlockBodyValidator.java Outdated Show resolved Hide resolved
...reum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetBlockBodyValidator.java Show resolved Hide resolved
@siladu
Normalise format for MainnetBlockValidator
5774acb 
Use toLogString
Fix bugs to put the logs back inside the guard.
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
garyschulte
garyschulte approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siladu siladu enabled auto-merge (squash) January 23, 2023 18:09
@siladu siladu disabled auto-merge January 23, 2023 18:10
@siladu
Remove irrelevant message about no error message (there is one printe…
bfb4c22 
…d by MainnetBlockBodyValidator)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu enabled auto-merge (squash) January 23, 2023 18:16
@siladu siladu merged commit 844db62 into hyperledger:main Jan 23, 2023
@siladu siladu deleted the improve-block-validation-logging branch January 23, 2023 21:45
fab-10 pushed a commit to fab-10/besu that referenced this pull request Feb 1, 2023
@siladu @fab-10
Improve MainnetBlockBodyValidator logging (hyperledger#4984)
c32d955 
Associate block number and hash with the various invalid block warnings

Print a less obscure message when there's no error message.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
ensi321 pushed a commit to ensi321/besu that referenced this pull request Feb 19, 2023
@siladu @ensi321
Improve MainnetBlockBodyValidator logging (hyperledger#4984)
3f4290d 
Associate block number and hash with the various invalid block warnings

Print a less obscure message when there's no error message.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu added the mainnet label Mar 6, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@siladu @elenduuche
Improve MainnetBlockBodyValidator logging (hyperledger#4984)
4857574 
Associate block number and hash with the various invalid block warnings

Print a less obscure message when there's no error message.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@siladu @eum602
Improve MainnetBlockBodyValidator logging (hyperledger#4984)
2b81c0f 
Associate block number and hash with the various invalid block warnings

Print a less obscure message when there's no error message.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siladu @shemnon @garyschulte