Initialize KZG native lib at startup if Cancun is enabled #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
added
the
doc-change-required
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
3 tasks
# Conflicts: # evm/src/main/java/org/hyperledger/besu/evm/precompile/KZGPointEvalPrecompiledContract.java # evm/src/test/java/org/hyperledger/besu/evm/precompile/KZGPointEvalPrecompileContractTest.java
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
… kzg-trusted-setup-param # Conflicts: # CHANGELOG.md # besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java # evm/src/main/java/org/hyperledger/besu/evm/precompile/KZGPointEvalPrecompiledContract.java # evm/src/test/java/org/hyperledger/besu/evm/precompile/KZGPointEvalPrecompileContractTest.java
… kzg-trusted-setup-param # Conflicts: # CHANGELOG.md # besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java # evm/src/main/java/org/hyperledger/besu/evm/precompile/KZGPointEvalPrecompiledContract.java # evm/src/test/java/org/hyperledger/besu/evm/precompile/KZGPointEvalPrecompileContractTest.java
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
… kzg-trusted-setup-param
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
shemnon
previously requested changes
Feb 16, 2023
| private static final Bytes successResult; | ||
|
|
||
| static { | ||
| CKZG4844JNI.loadNativeLibrary(CKZG4844JNI.Preset.MAINNET); |
There was a problem hiding this comment.
Please move this initialization to a lazy or on-demand initialization.
This will incur a large startup penalty on every CLI call that touches the EVM. This imposes a debilitating penalty on the EVM Tool and will make using Besu in reference tests impractical.
There was a problem hiding this comment.
make sense, will move it in the init methods
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
shemnon
approved these changes
Feb 17, 2023
bgravenorst
removed
the
doc-change-required
ensi321
pushed a commit
to ensi321/besu
that referenced
this pull request
Mar 6, 2023
…r#5084) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…r#5084) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…r#5084) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Move c-kzg native lib initialization at startup, when all the other native lib are configured, and also because it is not only used by the precompile, but also for transaction validation.
Added the option
--kzg-trusted-setupto pass a custom setup file for custom networks or to override the default one for named networksFixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog