Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transaction simulator to use ProtocolSchedule.getByBlockHeader #5170

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Mar 6, 2023

PR description

Change transaction simulator to use ProtocolSchedule.getByBlockHeader

Fixed Issue(s)

related to #5158

Manually tested the eth_call, trace_replayBlockTransaction, trace_block, and trace_transaction RPCs on Goerli.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Acceptance Tests (Non Mainnet)

  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe marked this pull request as ready for review March 7, 2023 03:00
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe enabled auto-merge (squash) March 8, 2023 03:02
@jframe jframe merged commit 1624f74 into hyperledger:main Mar 8, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants