Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty body concept after shanghai #5174

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Fix empty body concept after shanghai #5174

merged 7 commits into from
Mar 7, 2023

Commits on Mar 6, 2023

  1. Fix empty body concept after shanghai 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0c39601 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Check protocolSchedule to create empty block and add withdrawals to e… 

    …mpty block check

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d4a6251 View commit details
    Browse the repository at this point in the history

  2. Add unit tests 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4f7c43d View commit details
    Browse the repository at this point in the history

  3. Extract block creation into a private method 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f782406 View commit details
    Browse the repository at this point in the history

  4. Nit changes 

    Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
    @gfukushima
    gfukushima committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b9dcdb4 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix-empty-block-on-CompleteBlocksTask

    @garyschulte
    garyschulte authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    0d305e6 View commit details
    Browse the repository at this point in the history

  6. Refactor test names 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    74ba4cf View commit details
    Browse the repository at this point in the history