Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] use constants for strings in test plugin #5203

Merged
merged 4 commits into from
Mar 13, 2023
Merged

[MINOR] use constants for strings in test plugin #5203

merged 4 commits into from
Mar 13, 2023

Conversation

macfarla
Copy link
Contributor

Use constants for strings in test plugin

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Acceptance Tests (Non Mainnet)

  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

@macfarla macfarla enabled auto-merge March 13, 2023 01:55
@macfarla macfarla disabled auto-merge March 13, 2023 02:02
@macfarla macfarla enabled auto-merge March 13, 2023 02:02
@macfarla macfarla disabled auto-merge March 13, 2023 02:03
@macfarla macfarla enabled auto-merge March 13, 2023 02:03
siladu
siladu approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla added this pull request to the merge queue Mar 13, 2023
auto-merge was automatically disabled March 13, 2023 02:20

Merge queue setting changed

@macfarla macfarla removed this pull request from the merge queue due to the queue being cleared Mar 13, 2023
@macfarla macfarla added this pull request to the merge queue Mar 13, 2023
@macfarla macfarla removed this pull request from the merge queue due to the queue being cleared Mar 13, 2023
@macfarla macfarla enabled auto-merge (squash) March 13, 2023 03:42
@macfarla macfarla merged commit 056e911 into hyperledger:main Mar 13, 2023
@macfarla macfarla deleted the refactor branch March 13, 2023 04:06
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@macfarla @elenduuche
constants for namespace values (hyperledger#5203)
e833cb7 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
constants for namespace values (hyperledger#5203)
9563536 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @siladu