reset cache after heal #5266
Merged
reset cache after heal #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
|
garyschulte
requested changes
Mar 24, 2023
| @@ -338,6 +338,9 @@ public TrieLogManager getTrieLogManager() { | |||
| @Override | |||
| public void setArchiveStateUnSafe(final BlockHeader blockHeader) { | |||
There was a problem hiding this comment.
this method name should change to reflect its use. IMO it isn't setting the archive unsafe for use like the name implies, but rather is resetting the archive cache and adding the new pivot as the only entry. Perhaps resetArchiveStateTo(BlockHeader)
Similarly, BonsaiWorldState.setArchiveUnsafe should be something more along the lines of resetWorldStateTo(BlockHeader)
These methods could use javadoc describing the intent
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* reset cache after heal Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* reset cache after heal Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
We found that sometimes after the heal we still have old snapshot in the cache because after the clearTrieLog some transaction pool thread are still running
The fix is to clear the cache after the snapsync and also add a snapshot of the new head
Fixed Issue(s)