Fix BFT creating invalid blocks on London when zero base fee is used #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jason.frame@consensys.net>
|
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
changed the title
Signed-off-by: Jason Frame <jason.frame@consensys.net>
I wasn't able to run the full suite of tests. A lot failed due to docker issues. Was able to run the BFT ATs though except the PKI ones which are failing due to lib issue (probably mac related) |
…n them locally Signed-off-by: Jason Frame <jason.frame@consensys.net>
…can't run them locally" This reverts commit ef4c4a7. Signed-off-by: Jason Frame <jason.frame@consensys.net>
Closed
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…yperledger#5276) Signed-off-by: Jason Frame <jason.frame@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…yperledger#5276) Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This fixes an issue where on IBFT and QBFT invalid blocks are created by the proposer when using London with a zeroBaseFee.
The cause of this is that the ZeroBaseFeeMarket was returning true for the implementsDataFee check which meant that the excessDataGas field was added to the block header. This is only valid after Shanghai.
Fixed Issue(s)
fixes #5270