Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error message when verifying enode syntax with xdns-enabled #5346

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Improved error message when verifying enode syntax with xdns-enabled #5346

merged 6 commits into from
Apr 17, 2023

Conversation

NickSneo
Copy link
Contributor

PR description

Improved error message when verifying enode syntax with xdns-enabled

Fixed Issue(s)

#2569

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.

@NickSneo
updated error message
2e486cb 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
spotless apply
2be96e7 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo
Copy link
Contributor Author

@macfarla Can you plz review?

@NickSneo
revert unrelated change
933235d 
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@macfarla macfarla enabled auto-merge (squash) April 17, 2023 00:42
NickSneo and others added 2 commits April 17, 2023 06:25
@NickSneo @macfarla
commit suggested change
cf4d864 
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@NickSneo @macfarla
commit suggested change
5eccb7c 
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
@macfarla macfarla disabled auto-merge April 17, 2023 00:57
@macfarla macfarla enabled auto-merge (squash) April 17, 2023 00:57
@macfarla macfarla merged commit 832886d into hyperledger:main Apr 17, 2023
@NickSneo NickSneo mentioned this pull request Apr 19, 2023
Closed
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@NickSneo @macfarla @elenduuche
Improved error message when verifying enode syntax with xdns-enabled (h…
15c12e0 
…yperledger#5346)

* updated error message

Signed-off-by: Nischal Sharma <nischal@web3labs.com>

---------

Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@NickSneo @macfarla @eum602
Improved error message when verifying enode syntax with xdns-enabled (h…
1da84c5 
…yperledger#5346)

* updated error message

Signed-off-by: Nischal Sharma <nischal@web3labs.com>

---------

Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickSneo @macfarla