Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quorum-mainnet-launcher #5355

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Remove quorum-mainnet-launcher #5355

merged 4 commits into from
Apr 18, 2023

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Apr 18, 2023 •
edited
Loading

Fixes compilation errors (dependency not found)

https://app.circleci.com/pipelines/github/hyperledger/besu/21741/workflows/75a54db3-8824-4caf-87b8-bad4d63050fc/jobs/134348
Execution failed for task ':downloadLicenses'.
> Could not resolve all dependencies for configuration ':acceptance-tests:dsl:runtimeClasspath'.
   > Could not find net.consensys.services:quorum-mainnet-launcher:1.0.1.
     Required by:
         project :acceptance-tests:dsl > project :besu

Don't think we need to keep this ... plenty of mainnet guides for configuration files
would need to have dedicated time to make useful for PoS

@macfarla
remove launcher
f01b7b1 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
remove launcher from besucommand
8be7ab5 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited by macfarla
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla added mainnet dependencies dev experience The build system, things that enable easier development etc. doc-change-required Indicates an issue or PR that requires doc to be updated labels Apr 18, 2023
@macfarla
Copy link
Contributor Author

Launcher docs - https://besu.hyperledger.org/en/stable/public-networks/get-started/start-node/?h=launcher#besu-launcher

gfukushima
gfukushima approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

usmansaleem
usmansaleem approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
merge; changelog
f4ef2d8 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
edit
87fa67a 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla mentioned this pull request Apr 18, 2023
Merged
4 tasks
@macfarla macfarla merged commit 78f8eff into hyperledger:main Apr 18, 2023
@macfarla macfarla deleted the rm-launcher branch April 18, 2023 22:28
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Apr 20, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@macfarla @elenduuche
Remove quorum-mainnet-launcher (hyperledger#5355)
66064ad 
* remove launcher from besucommand

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
Remove quorum-mainnet-launcher (hyperledger#5355)
debe44b 
* remove launcher from besucommand

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
dependencies dev experience The build system, things that enable easier development etc. mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@macfarla @usmansaleem @gfukushima @alexandratran