Bonsai TrieLogFactory serializer/deserializer #5372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…ge as cleared Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…e rather than slotHash Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…es equivalence check Signed-off-by: garyschulte <garyschulte@gmail.com>
…in TrieLogLayer.addCodeChange rather than Bytes.EMPTY Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
zkbesu-755/trielogfactory
branch
from
53791d4
to
7f8ea0b
Compare
garyschulte
commented
Apr 20, 2023
| address, | ||
| new BonsaiValue<>( | ||
| oldValue == null ? Bytes.EMPTY : oldValue, newValue == null ? Bytes.EMPTY : newValue)); | ||
| code.put(address, new BonsaiValue<>(oldValue, newValue, newValue == null)); |
There was a problem hiding this comment.
@matkt I believe we were previously returning Bytes.EMPTY here because the old BonsaiLayeredWorldState implementation would serve state directly from TrieLogs.
Since the 5123 bonsai refactor, we should be able to treat this consistently as null. Otherwise a constructed trielog != that same trielog serialized and then deserialized. It was the difference between code == null vs code == 0x.
|
Based on my observations, I haven't noticed any decrease in performance. The time it takes to process blocks is very similar, and after analyzing the CPU profiling, I haven't identified any additional strain.
|
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* add account zero reads, mark self-destructed accounts, code and storage as cleared * refactor BonsaiWorldView and TrieLog to use StorageSlotKey record type rather than slotHash * add isCleared to read/write of BonsaiValues * for consistency between serialize and deserialize, use null directly in TrieLogLayer.addCodeChange rather than Bytes.EMPTY Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* add account zero reads, mark self-destructed accounts, code and storage as cleared * refactor BonsaiWorldView and TrieLog to use StorageSlotKey record type rather than slotHash * add isCleared to read/write of BonsaiValues * for consistency between serialize and deserialize, use null directly in TrieLogLayer.addCodeChange rather than Bytes.EMPTY Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR introduces a TrieLogFactory interface and default implementation that will allow for a pluggable implementation of bonsai trie log serialization and deserialization.
This pr also introduces a StorageSlotKey record type that enables accumulators and serializers to utilize slotKeys and/or slotKeyHashes when writing trieLogs.
Fixed Issue(s)
related to protocol-misc # 755