Unified protocol schedule tidy up #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that ProtocolScheduleBuilder is the only subclass Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
getByBlockHeader is still nullable so cannot remove the ProhibitedWithdrawals fallback afterall Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…amps are in the main protocolschedule Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu
added
TeamGroot
|
…ocolSchedule Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
This was originally extracted when this was part of an inheritence hierarchy Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* Fold AbstractProtocolScheduleBuilder into ProtocolScheduleBuilder * Tidy up WithdrawalsValidatorProvider * Remove unnecessary createSchedule in JsonRpcMethodsFactory now timestamps are in the main protocolschedule * Fold BlockNumberStreamingProtocolSchedule into MilestoneStreamingProtocolSchedule * Rename UnifiedProtocolSchedule to DefaultProtocolSchedule * inline ProtocolScheduleBuilder.postBuildStep Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Fold AbstractProtocolScheduleBuilder into ProtocolScheduleBuilder * Tidy up WithdrawalsValidatorProvider * Remove unnecessary createSchedule in JsonRpcMethodsFactory now timestamps are in the main protocolschedule * Fold BlockNumberStreamingProtocolSchedule into MilestoneStreamingProtocolSchedule * Rename UnifiedProtocolSchedule to DefaultProtocolSchedule * inline ProtocolScheduleBuilder.postBuildStep Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some straight forward refactorings and tidy up
Fixed Issue(s)
Part of #5354
Testing