Bug Fix eth_feeHistory - Issue-#4231 #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
|
Signed-off-by: George Tebrean <george@web3labs.com>
Signed-off-by: George Tebrean <george@web3labs.com>
macfarla
approved these changes
May 2, 2023
.../test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistoryTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistoryTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistoryTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthFeeHistoryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…sonrpc/internal/methods/EthFeeHistoryTest.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…sonrpc/internal/methods/EthFeeHistoryTest.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…sonrpc/internal/methods/EthFeeHistoryTest.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…sonrpc/internal/methods/EthFeeHistoryTest.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* fix eth_feeHistory Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* fix eth_feeHistory Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix the eth_feeHistory response. Seems that more rewards, baseFeePerGas and gasUsedRatio are returned when highestBlock requested is lower than blockCount. This is due to the fact that for this case the range wasn't calculated properly and exceeded
resolvedHighestBlockNumberwith more than +1.Fixed Issue(s)
#4231