Add option to send SNI header in TLS ClientHello message [#4894] #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
megglos
force-pushed
the
4894-tls-sni-header
branch
2 times, most recently
from
ed54779
to
941a489
Compare
…#4894) * add --Xp2p-tls-clienthello-sni option to enable the SNI header Issue hyperledger#4894 Signed-off-by: Sebastian Bathke <sebastian.bathke@gmail.com>
megglos
force-pushed
the
4894-tls-sni-header
branch
from
941a489
to
cfc422f
Compare
|
it needs the label |
macfarla
added
the
doc-change-required
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
fab-10
pushed a commit
to fab-10/besu
that referenced
this pull request
May 10, 2023
* Update dependencies - commons-net (hyperledger#5444) * update antlr and commons-net dependencies Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * revert antlr uprev Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * comment Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Add option to send SNI header in TLS ClientHello message (hyperledger#4894) (hyperledger#5439) * add --Xp2p-tls-clienthello-sni option to enable the SNI header Issue hyperledger#4894 Signed-off-by: Sebastian Bathke <sebastian.bathke@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sebastian Bathke <sebastian.bathke@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * ZkTrieLogFactoryImpl, rebased off of main Signed-off-by: garyschulte <garyschulte@gmail.com> * code before account Signed-off-by: garyschulte <garyschulte@gmail.com> * trielog shipping observer Signed-off-by: garyschulte <garyschulte@gmail.com> * use hex encoding in trielog shipping, add a TESTING default ZkTrieLogObserver to AbstractTrieLogManager Signed-off-by: garyschulte <garyschulte@gmail.com> * fix unintended recursion Signed-off-by: garyschulte <garyschulte@gmail.com> * filter out self destruct storage changes in ZkTrieLogImpl Signed-off-by: garyschulte <garyschulte@gmail.com> * store both slotHash and slotKey, defer to shomei to handle it as it sees fit Signed-off-by: garyschulte <garyschulte@gmail.com> * reorder trielog storage to differentiate between ZERO slot key and null slot key Signed-off-by: garyschulte <garyschulte@gmail.com> * do not filter unchanged accounts for zktrielogfactory Signed-off-by: garyschulte <garyschulte@gmail.com> * use blockHeader during trielog construction, add blockNumber to trielog, add blockHeader to trielogaddedevent Signed-off-by: garyschulte <garyschulte@gmail.com> * add blockNumber to rpc call to shomei Signed-off-by: garyschulte <garyschulte@gmail.com> * add isSyncing to the trieLogParameter and ZkTrieLogObserver Signed-off-by: garyschulte <garyschulte@gmail.com> * initial plumbing for trielog shipping plugin Signed-off-by: garyschulte <garyschulte@gmail.com> * halfway through generics hell Signed-off-by: garyschulte <garyschulte@gmail.com> * TrieLogs in plugin data Signed-off-by: garyschulte <garyschulte@gmail.com> * end of friday, green build with plugin refactoring, still need to add TrieLog Plugin Service Signed-off-by: garyschulte <garyschulte@gmail.com> * remove errant reference to ZkTrieLogFactory Signed-off-by: garyschulte <garyschulte@gmail.com> * adding dagger-wired plugincontext and TrieLogService Signed-off-by: garyschulte <garyschulte@gmail.com> * javadoc and fixes Signed-off-by: garyschulte <garyschulte@gmail.com> * add plugin observer subscription Signed-off-by: garyschulte <garyschulte@gmail.com> * plugin-api hash Signed-off-by: garyschulte <garyschulte@gmail.com> * fix besuComponent ref, move addService up into BesuContext Signed-off-by: garyschulte <garyschulte@gmail.com> * add TrieLogRangePair composition of blocknumber and TrieLog, use that for getTrieLogByRange return Signed-off-by: garyschulte <garyschulte@gmail.com> * javadoc Signed-off-by: garyschulte <garyschulte@gmail.com> * move TrieLog from datatypes to plugin-api Signed-off-by: garyschulte <garyschulte@gmail.com> * add blockHash to TrieLogRangeTuple Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Sebastian Bathke <sebastian.bathke@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sebastian Bathke <sebastian.bathke@camunda.com> Co-authored-by: Sebastian Bathke <sebastian.bathke@gmail.com>
alexandratran
removed
the
doc-change-required
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…#4894) (hyperledger#5439) * add --Xp2p-tls-clienthello-sni option to enable the SNI header Issue hyperledger#4894 Signed-off-by: Sebastian Bathke <sebastian.bathke@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sebastian Bathke <sebastian.bathke@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…#4894) (hyperledger#5439) * add --Xp2p-tls-clienthello-sni option to enable the SNI header Issue hyperledger#4894 Signed-off-by: Sebastian Bathke <sebastian.bathke@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sebastian Bathke <sebastian.bathke@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds an option to send an SNI header on a TLS ClientHello message. Given the existing exposed options for the
TLSConfiguration, I went for the--Xp2p-tls-*prefix for the new sni header option, instead ofp2p-tls-clienthello-snias it was stated in #4894 . Please let me know if you prefer otherwise.Fixed Issue(s)
fixes #4894