Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker image failing to start Besu with NoClassDefFoundError for org.xerial.snappy.Snappy #5462

Merged
merged 8 commits into from
May 17, 2023
Merged

Fix Docker image failing to start Besu with NoClassDefFoundError for org.xerial.snappy.Snappy #5462

merged 8 commits into from
May 17, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented May 16, 2023 •
edited
Loading

PR description

Fix Besu failing to start when using Docker 23.4.0 due to NoClassDefFoundError for org.xerial.snappy.Snappy.

The cause was that we are using an older version of glibc for some Docker images due to the older version of the Ubuntu distro being used.

Changes

Related to the update of the snappy library xerial/snappy-java#417 (comment)

Fixed Issue(s)

fixes #5463

@jframe
Update docker images to use ubuntu:22.04 to fix issue with loading sn…
af2505b 
…appy library

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited by jframe
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@jframe jframe changed the title Update docker images to use ubuntu:22.04 to fix issue with loading sn… Update docker images to use ubuntu:22.04 to fix NoClassDefFoundError for org.xerial.snappy.Snappy May 16, 2023
@jframe jframe changed the title Update docker images to use ubuntu:22.04 to fix NoClassDefFoundError for org.xerial.snappy.Snappy Fix NoClassDefFoundError for org.xerial.snappy.Snappy May 16, 2023
@siladu
Copy link
Contributor

siladu commented May 16, 2023

Probably doesn't use snappy, but reckon we should do https://github.com/hyperledger/besu/blob/main/ethereum/evmtool/src/main/docker/Dockerfile for completeness?

@jframe
Copy link
Contributor Author

jframe commented May 16, 2023

Probably doesn't use snappy, but reckon we should do https://github.com/hyperledger/besu/blob/main/ethereum/evmtool/src/main/docker/Dockerfile for completeness?

Seems like a sensible thing to do. Will update it.

@jframe
Update evmtool docker image to use ubuntu:22.04 to fix issue with loa…
007a003 
…ding snappy library

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Update debug docker image to include wget again
42b53cd 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Add changelog
3a3595c 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe marked this pull request as ready for review May 16, 2023 05:59
macfarla
macfarla approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

siladu
siladu approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe
Install ca-certificates-java to fix Docker build issue with openjdk17
67049c1 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Install ca-certificates-java to fix Docker build issue with openjdk17…
f95a063 
… for evmtool

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe changed the title Fix NoClassDefFoundError for org.xerial.snappy.Snappy Fix Docker NoClassDefFoundError for org.xerial.snappy.Snappy May 17, 2023
gfukushima
gfukushima approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jframe
Include mention of docker in changelog
932a6f9 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Update changelog to mention breaking of glibc in 23.4.0
a208c5c 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe enabled auto-merge (squash) May 17, 2023 02:11
@jframe jframe changed the title Fix Docker NoClassDefFoundError for org.xerial.snappy.Snappy Fix Docker image failing to start Besu with NoClassDefFoundError for org.xerial.snappy.Snappy May 17, 2023
@jframe jframe disabled auto-merge May 17, 2023 02:11
@jframe jframe enabled auto-merge (squash) May 17, 2023 02:12
@jframe jframe merged commit 9b06f12 into hyperledger:main May 17, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@jframe @elenduuche
Fix Docker image failing to start Besu with NoClassDefFoundError for …
99a23e5 
…org.xerial.snappy.Snappy (hyperledger#5462)

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@macfarla macfarla mentioned this pull request Sep 26, 2023
Closed
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@jframe @eum602
Fix Docker image failing to start Besu with NoClassDefFoundError for …
d9d4c9a 
…org.xerial.snappy.Snappy (hyperledger#5462)

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

@siladu siladu siladu approved these changes

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jframe @siladu @macfarla @gfukushima