Prevent rocksdb segfaults when accessing closed storage #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
garyschulte
changed the title
garyschulte
force-pushed
the
bugfix/5362-tx-safety
branch
from
5856e30
to
70bdee0
Compare
macfarla
approved these changes
Jun 2, 2023
| @@ -114,4 +114,11 @@ public interface KeyValueStorage extends Closeable { | |||
| * @throws StorageException problem encountered when starting a new transaction. | |||
| */ | |||
| KeyValueStorageTransaction startTransaction() throws StorageException; | |||
|
|
|||
| /** | |||
| * Return Whether the underlying storage is closed or not. | |||
There was a problem hiding this comment.
Suggested change
| * Return Whether the underlying storage is closed or not. | |
| * Return Whether the underlying storage is closed. |
| private void throwIfClosed() { | ||
| if (parent.isClosed()) { | ||
| LOG.error("Attempting to use a closed RocksDBKeyValueStorage"); | ||
| throw new IllegalStateException("Storage has been closed"); |
There was a problem hiding this comment.
RocksDBSnapshotTransaction uses StorageException - does it make sense to match that here?
throw new StorageException("Storage has already been closed");
There was a problem hiding this comment.
Yes, I think storage exception is better everywhere possible 👍
...es/kvstore/src/main/java/org/hyperledger/besu/services/kvstore/SegmentedKeyValueStorage.java
Outdated
Show resolved
Hide resolved
...es/kvstore/src/main/java/org/hyperledger/besu/services/kvstore/SegmentedKeyValueStorage.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/hyperledger/besu/services/kvstore/SegmentedKeyValueStorageAdapter.java
Outdated
Show resolved
Hide resolved
…hutdown Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
… in debug Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/5362-tx-safety
branch
from
70bdee0
to
8a16110
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/5362-tx-safety
branch
from
8a16110
to
96140be
Compare
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…5527) * add isClosed check to Transaction decorator to prevent segfaults on shutdown Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…5527) * add isClosed check to Transaction decorator to prevent segfaults on shutdown Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
gate transaction access on whether the underlying storage has closed. This prevents segfaults at shutdown when we close rocksdb, but there are async processes attempting to access the db.
Currently evaluating to ensure there is no noticeable performance regression.
Fixed Issue(s)
#5362