Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster MCOPY implementation #5630

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Faster MCOPY implementation #5630

merged 3 commits into from
Jun 22, 2023

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jun 21, 2023

wire in deep call to System.arrayCopy instead of buffer copy.

PR description

Fixed Issue(s)

@shemnon
Faster MCOPY implementaiton
6ba4697 
wire in deep call to System.arrayCopy instead of buffer copy.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@shemnon
Copy link
Contributor Author

shemnon commented Jun 21, 2023

Small performance boost

code

./ethereum/evmtool/build/install/evmtool/bin/evm --gas 30000000 --repeat 1000000 --fork Cancun --code 4260d01b6000526008600060085E6010600060105E6020600060205E6040600060405E6080600060805E61010060006101005E61020060006102005E61040060006104005E61080060006108005E61100060006110005E61200060006120005E61400060006140005E61800060006180005E00

with PR (on mac M1 Max)

{"gasUser":"0x50ad","timens":9500,"time":9,"gasTotal":"0x50ad","output":"0x"}

without PR

{"gasUser":"0x50ad","timens":10250,"time":10,"gasTotal":"0x50ad","output":"0x"}

macfarla
macfarla approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evm/src/main/java/org/hyperledger/besu/evm/frame/Memory.java Outdated Show resolved Hide resolved
shemnon and others added 2 commits June 22, 2023 17:39
@shemnon @macfarla
Update evm/src/main/java/org/hyperledger/besu/evm/frame/Memory.java
ac9b740 
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
@shemnon
Merge branch 'main' into mcopy-faster
2d18573
@shemnon shemnon enabled auto-merge (squash) June 22, 2023 22:40
@shemnon shemnon merged commit a0e5dd6 into hyperledger:main Jun 22, 2023
davidkngo pushed a commit to liquichain/besu that referenced this pull request Jun 28, 2023
@shemnon @davidkngo
Faster MCOPY implementation (hyperledger#5630)
666c22f 
Faster MCOPY implementation

wire in deep call to System.arrayCopy instead of buffer copy.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo pushed a commit to liquichain/besu that referenced this pull request Jul 21, 2023
@shemnon @davidkngo
Faster MCOPY implementation (hyperledger#5630)
14409b4 
Faster MCOPY implementation

wire in deep call to System.arrayCopy instead of buffer copy.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo added a commit to liquichain/besu that referenced this pull request Jul 21, 2023
@davidkngo
Revert "Faster MCOPY implementation (hyperledger#5630)"
dde18a3 
This reverts commit 14409b4.
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@shemnon @elenduuche
Faster MCOPY implementation (hyperledger#5630)
d3c414e 
Faster MCOPY implementation

wire in deep call to System.arrayCopy instead of buffer copy.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@shemnon @eum602
Faster MCOPY implementation (hyperledger#5630)
2becfc8 
Faster MCOPY implementation

wire in deep call to System.arrayCopy instead of buffer copy.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @macfarla