Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] config module - junit5 #5631

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[MINOR] config module - junit5 #5631

merged 1 commit into from
Jun 22, 2023

Conversation

macfarla
Copy link
Contributor

Fixes #5570

@macfarla
junit5
261524f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla enabled auto-merge (squash) June 22, 2023 04:30
jframe
jframe approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 5ee0836 into hyperledger:main Jun 22, 2023
davidkngo pushed a commit to liquichain/besu that referenced this pull request Jun 28, 2023
@macfarla @davidkngo
junit5 (hyperledger#5631)
a6be27c 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
davidkngo pushed a commit to liquichain/besu that referenced this pull request Jul 21, 2023
@macfarla @davidkngo
junit5 (hyperledger#5631)
48d8bae 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
davidkngo added a commit to liquichain/besu that referenced this pull request Jul 21, 2023
@davidkngo
Revert "junit5 (hyperledger#5631)"
3925ce5 
This reverts commit 48d8bae.
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@macfarla @elenduuche
junit5 (hyperledger#5631)
f5e42e9 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
junit5 (hyperledger#5631)
51a46ad 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config - migrate tests from Junit4 to Junit5
2 participants
@macfarla @jframe