Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4844] CancunGasCalculator -> Fix Excess Data Gas Calculation #5643

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Fixing the formula according to calc_excess_data_gas in https://eips.ethereum.org/EIPS/eip-4844

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title [4844] CancunGasCalculator -> Fix compute Excess Data Gas [4844] CancunGasCalculator -> Fix Excess Data Gas Calculation Jun 27, 2023
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised none of the unit tests were impacted, which lead me to discover we have no coverage for this. Can you please add unit tests to cover it?

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Copy link
Contributor Author

I'm surprised none of the unit tests were impacted, which lead me to discover we have no coverage for this. Can you please add unit tests to cover it?

done

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 0e229ac into hyperledger:4844-devnet-5b Jun 28, 2023
5 checks passed
jflo pushed a commit that referenced this pull request Jun 29, 2023
* Fix computeExcessDataGas formula

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit that referenced this pull request Jun 30, 2023
* Fix computeExcessDataGas formula

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit that referenced this pull request Jul 5, 2023
* Fix computeExcessDataGas formula

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
…edger#5643)

* Fix computeExcessDataGas formula

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the fix-cancun-data-gas-formula branch September 20, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants