-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4844] CancunGasCalculator -> Fix Excess Data Gas Calculation #5643
[4844] CancunGasCalculator -> Fix Excess Data Gas Calculation #5643
Conversation
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised none of the unit tests were impacted, which lead me to discover we have no coverage for this. Can you please add unit tests to cover it?
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
done |
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0e229ac
into
hyperledger:4844-devnet-5b
* Fix computeExcessDataGas formula Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
* Fix computeExcessDataGas formula Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
* Fix computeExcessDataGas formula Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…edger#5643) * Fix computeExcessDataGas formula Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
PR description
Fixing the formula according to
calc_excess_data_gas
in https://eips.ethereum.org/EIPS/eip-4844