[4844] Check params earlier and move blob validation to a new method #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia
merged commit 7a26a4c
into
hyperledger:4844-devnet-5b
5 checks passed
jflo
pushed a commit
that referenced
this pull request
Jun 30, 2023
…5663) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo
pushed a commit
that referenced
this pull request
Jul 5, 2023
…5663) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jul 20, 2023
…yperledger#5663) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Check the params earlier and move blob validation to a new method
In case CL sends a payload with invalid blob params for a known header, we should return invalid.
Expected Behaviour: return invalid
Actual Behaviour: Returns are valid because we have already seen that payload.
This PR moves the validation earlier in the flow and encapsulates the validation login into a method for readability.