Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4844] NewPayloadV3 - Add fork validation and fixes #5667

Merged
merged 6 commits into from
Jul 4, 2023
Merged

[4844] NewPayloadV3 - Add fork validation and fixes #5667

merged 6 commits into from
Jul 4, 2023

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

  • This PR implements a fork validation for the newPayloadV3

Unrelated:

  • Change the type of dataGasUsed to Long instead of long
  • Add acceptance tests for Engine API - Cancun

@Gabriel-Trintinalia
Change dataGasUsed type to Long and implement fork validation
8276d16 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Change invalid fork json error
798cacc 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Fix missing dataGasUsed types and add engine acceptance test
16cf7eb 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title Implement fork validation and fixes [4844] NewPayloadV3 Implement fork validation and fixes Jul 4, 2023
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title [4844] NewPayloadV3 Implement fork validation and fixes [4844] NewPayloadV3 - Add fork validation and fixes Jul 4, 2023
@Gabriel-Trintinalia
Fix wrong data type
57581fd 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Ignore Engine cancun test for now
1b69441 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Remove Cancun Acceptance test
628a4ab 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 3372c32 into hyperledger:4844-devnet-5b Jul 4, 2023
@Gabriel-Trintinalia Gabriel-Trintinalia mentioned this pull request Jul 4, 2023
Closed
jflo pushed a commit that referenced this pull request Jul 5, 2023
@Gabriel-Trintinalia @jflo
[4844] NewPayloadV3 - Add fork validation and fixes (#5667)
2bb9972 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@Gabriel-Trintinalia @jflo
[4844] NewPayloadV3 - Add fork validation and fixes (hyperledger#5667)
66e4998 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the hive-fork-valitation branch September 20, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4844 mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gabriel-Trintinalia