Introduce transaction validator interface (phase 1) #5673

fab-10 · 2023-07-05T09:56:34Z

PR description

The main goal of this PR is the introduction of the TransactionValidator interface to pave the way for future simpler custom transaction validation necessary on private networks and/or specialized networks.
The work is not completed yet, and more PRs will be made, the next one will address the removal of the odd method setPermissionTransactionFilter from the interface

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

github-actions · 2023-07-05T09:56:45Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/DefaultProtocolSchedule.java

+            spec.spec()
+                .getTransactionValidator()
+                .setPermissionTransactionFilter(permissionTransactionFilter));


siladu · 2023-07-06T07:49:32Z

...tion/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockTransactionSelector.java

@@ -472,10 +465,6 @@ private boolean isTransientValidationError(final TransactionInvalidReason invali
        || invalidReason.equals(TransactionInvalidReason.NONCE_TOO_HIGH);
  }

-  private boolean isIncorrectNonce(final ValidationResult<TransactionInvalidReason> result) {


Why is this being removed? Is the functionality happening elsewhere?

yes it has been generalized, now every invalid reason is recorded in the TransactionSelectionResults.invalidTransactions map, not only for incorrect nonce, and the caller have full access to all invalid transactions

siladu · 2023-07-06T07:50:02Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/PermissionTransactionFilter.java

 */
 package org.hyperledger.besu.ethereum.core;

 @FunctionalInterface
-public interface TransactionFilter {
+public interface PermissionTransactionFilter {


siladu

LGTM

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc comments Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only update peer with the first and last block (#5659) * only update peer with the first and last block Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Put download links into CHANGELOG and do some clean up (#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add --amend to docker manifest create to fix docker latest tag (#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add Xlayered-tx-pool to the config log printout (#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add hooks to AbstractCreateOperation for library users (#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Test updates for cancun execution-spec-tests (#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Upgrade BouncyCastle libraries (#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Introduce transaction validator interface (phase 1) (#5673) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only validate `--miner-enabled` option for ethash networks (#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update tuweni2.4.2 (#5684) * Revert "Revert "Update Tuweni to 2.4.1 (#5513)" (#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> --------- Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Do not leak references to PendingTransactions (#5693) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove v0 version of the database (#5698) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updated plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix import Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: matkt <karim.t2am@gmail.com>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc comments Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only update peer with the first and last block (hyperledger#5659) * only update peer with the first and last block Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Put download links into CHANGELOG and do some clean up (hyperledger#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add --amend to docker manifest create to fix docker latest tag (hyperledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add Xlayered-tx-pool to the config log printout (hyperledger#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add hooks to AbstractCreateOperation for library users (hyperledger#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Test updates for cancun execution-spec-tests (hyperledger#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Upgrade BouncyCastle libraries (hyperledger#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Introduce transaction validator interface (phase 1) (hyperledger#5673) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only validate `--miner-enabled` option for ethash networks (hyperledger#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update tuweni2.4.2 (hyperledger#5684) * Revert "Revert "Update Tuweni to 2.4.1 (hyperledger#5513)" (hyperledger#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> --------- Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Do not leak references to PendingTransactions (hyperledger#5693) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove v0 version of the database (hyperledger#5698) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updated plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix import Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: matkt <karim.t2am@gmail.com>

…ger#5673)" This reverts commit ecb3486.

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc comments Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only update peer with the first and last block (hyperledger#5659) * only update peer with the first and last block Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Put download links into CHANGELOG and do some clean up (hyperledger#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add --amend to docker manifest create to fix docker latest tag (hyperledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add Xlayered-tx-pool to the config log printout (hyperledger#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add hooks to AbstractCreateOperation for library users (hyperledger#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Test updates for cancun execution-spec-tests (hyperledger#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Upgrade BouncyCastle libraries (hyperledger#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Introduce transaction validator interface (phase 1) (hyperledger#5673) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only validate `--miner-enabled` option for ethash networks (hyperledger#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update tuweni2.4.2 (hyperledger#5684) * Revert "Revert "Update Tuweni to 2.4.1 (hyperledger#5513)" (hyperledger#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> --------- Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Do not leak references to PendingTransactions (hyperledger#5693) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove v0 version of the database (hyperledger#5698) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updated plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix import Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: matkt <karim.t2am@gmail.com>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Extend OperationTracer with new methods, create Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Rename ExtendedOperationTracer to BlockAwareOperationTracer Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc comments Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update evm/src/main/java/org/hyperledger/besu/evm/tracing/OperationTracer.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only update peer with the first and last block (hyperledger#5659) * only update peer with the first and last block Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Put download links into CHANGELOG and do some clean up (hyperledger#5660) * put the download links for 23.4.4 into the CHANGELOG.md * clean up CHANGELOG Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add --amend to docker manifest create to fix docker latest tag (hyperledger#5661) We need to replace previous release's latest tag. Might be broken due to a recent change in the docker command implementation Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add Xlayered-tx-pool to the config log printout (hyperledger#5665) Unrelated: clarify epoch length in javadoc Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add hooks to AbstractCreateOperation for library users (hyperledger#5656) Add hooks for a successful contract create, a failed contract create, and an invalid contact create. Users of the library will be able to customize create responses without having to replace core logic. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Test updates for cancun execution-spec-tests (hyperledger#5670) - support legacy V values (larger V value) and type 1+ (v is recId only) - new fields - shared transaction extraction - rejection detection Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Upgrade BouncyCastle libraries (hyperledger#5675) Upgrade bouncy castle to v1.75. This involved a change in maven coordinates for other modules. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Introduce transaction validator interface (phase 1) (hyperledger#5673) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Only validate `--miner-enabled` option for ethash networks (hyperledger#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update tuweni2.4.2 (hyperledger#5684) * Revert "Revert "Update Tuweni to 2.4.1 (hyperledger#5513)" (hyperledger#5585)" This reverts commit 6111e1b. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * update Tuweni to 2.4.2 Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> --------- Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Do not leak references to PendingTransactions (hyperledger#5693) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove v0 version of the database (hyperledger#5698) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updated plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * spotless Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating plugin api hash Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * moved transcation interface to datatypes to use it in the OperationTracer.traceStartTransaction method Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fix import Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew1001@hotmail.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: matkt <karim.t2am@gmail.com>

fab-10 added 3 commits July 5, 2023 11:38

some code opt

ce4ea3d

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Introduce TransactionValidator interface

cddd557

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Move isReplayProtectionSupported to ProtocolSpec

6b29fba

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Renaming and deprecation of the permission transaction filter

8f68496

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

fab-10 force-pushed the txvalidator-interface branch from edb2104 to 8f68496 Compare July 5, 2023 10:07

github-advanced-security bot found potential problems Jul 5, 2023

View reviewed changes

fab-10 marked this pull request as ready for review July 5, 2023 10:40

fab-10 changed the title ~~Introduce transaction validator interface~~ Introduce transaction validator interface (phase 1) Jul 5, 2023

siladu reviewed Jul 6, 2023

View reviewed changes

fab-10 requested a review from siladu July 6, 2023 09:50

siladu approved these changes Jul 6, 2023

View reviewed changes

Merge branch 'main' into txvalidator-interface

af524e9

fab-10 enabled auto-merge (squash) July 7, 2023 07:28

fab-10 merged commit 6ac03af into hyperledger:main Jul 7, 2023

fab-10 deleted the txvalidator-interface branch July 7, 2023 13:05

fab-10 mentioned this pull request Jul 7, 2023

Introduce transaction validator interface (phase 2) #5682

Merged

daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Jul 13, 2023

Introduce transaction validator interface (phase 1) (hyperledger#5673)

b727cef

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

davidkngo pushed a commit to liquichain/besu that referenced this pull request Jul 21, 2023

Introduce transaction validator interface (phase 1) (hyperledger#5673)

ecb3486

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

davidkngo added a commit to liquichain/besu that referenced this pull request Jul 21, 2023

Revert "Introduce transaction validator interface (phase 1) (hyperled…

4c9b430

…ger#5673)" This reverts commit ecb3486.

elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023

Introduce transaction validator interface (phase 1) (hyperledger#5673)

3bb2901

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

Introduce transaction validator interface (phase 1) (hyperledger#5673)

84f7240

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce transaction validator interface (phase 1) #5673

Introduce transaction validator interface (phase 1) #5673

fab-10 commented Jul 5, 2023 •

edited

Loading

github-actions bot commented Jul 5, 2023 •

edited by fab-10

Loading

siladu Jul 6, 2023

fab-10 Jul 6, 2023

siladu Jul 6, 2023

siladu left a comment

Introduce transaction validator interface (phase 1) #5673

Introduce transaction validator interface (phase 1) #5673

Conversation

fab-10 commented Jul 5, 2023 • edited Loading

PR description

github-actions bot commented Jul 5, 2023 • edited by fab-10 Loading

siladu Jul 6, 2023

Choose a reason for hiding this comment

fab-10 Jul 6, 2023

Choose a reason for hiding this comment

siladu Jul 6, 2023

Choose a reason for hiding this comment

siladu left a comment

Choose a reason for hiding this comment

fab-10 commented Jul 5, 2023 •

edited

Loading

github-actions bot commented Jul 5, 2023 •

edited by fab-10

Loading