Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4844] [Hive] Fix for genesis mismatch #5677

Merged
merged 2 commits into from
Jul 6, 2023
Merged

[4844] [Hive] Fix for genesis mismatch #5677

merged 2 commits into from
Jul 6, 2023

Conversation

Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented Jul 6, 2023 •
edited
Loading

PR description

Fix from @spencer-tb

#5664 (comment)

We recently added the hive pyspec simulator to https://hivecancun.ethdevops.io/, which runs the tests from https://github.com/ethereum/execution-spec-tests using the EngineAPI

In order to start running the tests the genesis state needs to include the excessDataGas and dataGasUsed, otherwise we get a genesis mismatch -> leading to a SYNCING status when adding the first block with NewPayloadV3 via the EngineAPI, as opposed to a VALID or expected INVALID status.

We recently added the hive pyspec simulator to https://hivecancun.ethdevops.io/, which runs the tests from https://github.com/ethereum/execution-spec-tests using the EngineAPI

In order to start running the tests the genesis state needs to include the excessDataGas and dataGasUsed, otherwise we get a genesis mismatch -> leading to a SYNCING status when adding the first block with NewPayloadV3 via the EngineAPI, as opposed to a VALID or expected INVALID status.

spencer-tb and others added 2 commits July 6, 2023 09:23
@spencer-tb @Gabriel-Trintinalia
fix for genesis mismatch
69067c5 
Signed-off-by: spencer-tb <spencer@spencertaylorbrown.uk>
@Gabriel-Trintinalia
Fix tests and spotless
17250ab 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review July 6, 2023 00:46
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 6f54eab into hyperledger:4844-devnet-5b Jul 6, 2023
This was referenced Jul 6, 2023
Closed
Closed
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@Gabriel-Trintinalia @spencer-tb @jflo
[4844] [Hive] Fix for genesis mismatch (hyperledger#5677)
decc6d5 
* fix for genesis mismatch

Signed-off-by: spencer-tb <spencer@spencertaylorbrown.uk>

* Fix tests and spotless

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: spencer-tb <spencer@spencertaylorbrown.uk>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the pyspec-genesis-file branch September 20, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4844 mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriel-Trintinalia @spencer-tb