Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-4844 testing support #5702

Merged
merged 6 commits into from
Jul 26, 2023
Merged

EIP-4844 testing support #5702

merged 6 commits into from
Jul 26, 2023

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jul 13, 2023

  • Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
  • Rename DataHash to BlobHash (to align with EIP4844 text)

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@shemnon
EIP-4844 testing support
276b139 
Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
Rename DataHash to BlobHash (to align with EIP4844 text)

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
Merge branch 'main' of github.com:hyperledger/besu into reftest-4844-…
a98f020 
…support

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
null
c874f4d 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
macfarla
macfarla approved these changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shemnon and others added 3 commits July 26, 2023 11:03
@shemnon
merge
6cc57a5 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
Use versioned hash
2c532ea 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@jflo
Merge branch 'main' into reftest-4844-support
58f3e0a
@shemnon shemnon enabled auto-merge (squash) July 26, 2023 18:06
@shemnon shemnon merged commit 403297b into hyperledger:main Jul 26, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@shemnon @elenduuche
EIP-4844 testing support (hyperledger#5702)
0ab8d6e 
Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
Rename DataHash to BlobHash (to align with EIP4844 text)

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
@shemnon @garyschulte
EIP-4844 testing support (hyperledger#5702)
8ab3bdc 
Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
Rename DataHash to BlobHash (to align with EIP4844 text)

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
@shemnon @garyschulte
EIP-4844 testing support (hyperledger#5702)
4d77841 
Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
Rename DataHash to BlobHash (to align with EIP4844 text)

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Aug 28, 2023
@shemnon @garyschulte
EIP-4844 testing support (hyperledger#5702)
4a071b2 
Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
Rename DataHash to BlobHash (to align with EIP4844 text)

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@shemnon @eum602
EIP-4844 testing support (hyperledger#5702)
b8ae832 
Add two new fields to reference tests (versionedHashes, maxFeePerDataGas)
Rename DataHash to BlobHash (to align with EIP4844 text)

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shemnon @jflo @macfarla