Add missing methods to transaction interface #5732

daniellehrner · 2023-07-30T16:54:57Z

PR description

Missing methods which exist in the transaction class, but not the interface were added. This required the creation of a AccessListEntry interface in org.hyperledger.besu.datatypes and it's use in all the places that have used the class directly before.

Fixed Issue(s)

fixes #5731

github-actions · 2023-07-30T16:55:09Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

evm/src/main/java/org/hyperledger/besu/evm/AccessListEntry.java

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java

datatypes/src/main/java/org/hyperledger/besu/datatypes/AccessListEntry.java

…tEntry interface to add it to the transaction interface Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…tion.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…erledger#5727) * Make smart contract permissioning features work with london fork Override the transactionSimulator's default TransactionValidationParams with one that allows for exceeding the account balance (which effectively zeros the baseFee). This mimics the way that eth_estimateGas and eth_call are implemented. Similar change to hyperledger#5277 Update ATs to use londonBlock (existing genesis allocs necessitate zeroBaseFee as well) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…edger#5726) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Update Reference Tests to 12.3 * fix decoding error * add ignored field * update module Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…dger#5711) This way it is possible for the caller to have more data about the selection process. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* ensure we are on a single tuweni version * factor out an unneeded concatenate Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* add type * update changelog --------- Signed-off-by: George Tebrean <george@web3labs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Execution-spec-tests migrated from DataGas to BlobGas and checks for its inclusion in tests now. Add needed support. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…module Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…action Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

datatypes/src/main/java/org/hyperledger/besu/datatypes/AccessListEntry.java

garyschulte

🚢

Signed-off-by: garyschulte <garyschulte@gmail.com>

garyschulte · 2023-08-21T21:52:54Z

Took the liberty of pushing a commit to rename dataGas to blobGas in the Transaction interface. I would have just commented, but I had already resolved the merge conflict from the upstream PR that renamed dataGas to blobGas and the github UI did not offer a way to change the Transaction interface since it wasn't part of the merge conflict.

shemnon

APIs are forever, and I am hesitant to add fields that can be derived from other fields in an effort to keep the API surface as small as possible. That was the point of the separate datatypes module. Unless there is a compelling "This use case requires X" I would rather keep those derived data methods out of the interface.

4844 and access list fields are good, as there are no other ways to get at that data.

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java

shemnon · 2023-08-21T22:51:39Z

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java

+   *
+   * @param out the output to write the transaction to
+   */
+  void writeTo(final RLPOutput out);


One of my goals is to remove the RLP dependency from the datatypes module.

I've replaced it with a new generic method Bytes encoded();: see here

After diving into what it would take to remove it I'm thinking it should come back.

Because the CREATE operation depends on the RLP definitions to get the contract addresses the EVM module will still require the RLP, it's not just coming into EVM as a tag-along of datatypes. So removing RLP from datatypes is not really needed, as some of the RLP dependencies once it is determined they should stay are best handled where they are at design-wise.

For performance we will want to use a passed in RLPOutput object as well.

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java

…d through other means. Added new method encoded to return the encoded tx in Bytes instead of RLPOutput Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner · 2023-08-22T15:05:28Z

@shemnon I've adressed the changes, could you please review again?

shemnon

Optional: - move bytes encoded() to void writeTo(final RLPOutput out);

* added missing methods to transaction interface, created new AccessListEntry interface to add it to the transaction interface Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * CHANGELOG.md entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Make smart contract permissioning features work with london fork (hyperledger#5727) * Make smart contract permissioning features work with london fork Override the transactionSimulator's default TransactionValidationParams with one that allows for exceeding the account balance (which effectively zeros the baseFee). This mimics the way that eth_estimateGas and eth_call are implemented. Similar change to hyperledger#5277 Update ATs to use londonBlock (existing genesis allocs necessitate zeroBaseFee as well) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Correctly cache the TransactionValidator instance on creation (hyperledger#5726) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Reference tests 12.3 (hyperledger#5733) Update Reference Tests to 12.3 * fix decoding error * add ignored field * update module Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Return all not selected transactions, not only invalid ones. (hyperledger#5711) This way it is possible for the caller to have more data about the selection process. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Address import performance issues (hyperledger#5734) * ensure we are on a single tuweni version * factor out an unneeded concatenate Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add type to PendingTransactionDetail (hyperledger#5729) * add type * update changelog --------- Signed-off-by: George Tebrean <george@web3labs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Migrate to blobGas in execution-spec-tests (hyperledger#5745) Execution-spec-tests migrated from DataGas to BlobGas and checks for its inclusion in tests now. Add needed support. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove AccessListEntry interface and move its class to the datatypes module Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add missing cost methods to interface, add method to get RLP of transaction Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating hash with updated reference tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadocs Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed compiler errors in integration tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * retro blobGas name change into Transaction interface Signed-off-by: garyschulte <garyschulte@gmail.com> * removed methods from transaction interface which values can be derived through other means. Added new method encoded to return the encoded tx in Bytes instead of RLPOutput Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: George Tebrean <99179176+gtebrean@users.noreply.github.com> Co-authored-by: garyschulte <garyschulte@gmail.com>

* added missing methods to transaction interface, created new AccessListEntry interface to add it to the transaction interface Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * CHANGELOG.md entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Make smart contract permissioning features work with london fork (hyperledger#5727) * Make smart contract permissioning features work with london fork Override the transactionSimulator's default TransactionValidationParams with one that allows for exceeding the account balance (which effectively zeros the baseFee). This mimics the way that eth_estimateGas and eth_call are implemented. Similar change to hyperledger#5277 Update ATs to use londonBlock (existing genesis allocs necessitate zeroBaseFee as well) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Correctly cache the TransactionValidator instance on creation (hyperledger#5726) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Reference tests 12.3 (hyperledger#5733) Update Reference Tests to 12.3 * fix decoding error * add ignored field * update module Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Return all not selected transactions, not only invalid ones. (hyperledger#5711) This way it is possible for the caller to have more data about the selection process. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Address import performance issues (hyperledger#5734) * ensure we are on a single tuweni version * factor out an unneeded concatenate Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add type to PendingTransactionDetail (hyperledger#5729) * add type * update changelog --------- Signed-off-by: George Tebrean <george@web3labs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Migrate to blobGas in execution-spec-tests (hyperledger#5745) Execution-spec-tests migrated from DataGas to BlobGas and checks for its inclusion in tests now. Add needed support. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove AccessListEntry interface and move its class to the datatypes module Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add missing cost methods to interface, add method to get RLP of transaction Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating hash with updated reference tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadocs Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed compiler errors in integration tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * retro blobGas name change into Transaction interface Signed-off-by: garyschulte <garyschulte@gmail.com> * removed methods from transaction interface which values can be derived through other means. Added new method encoded to return the encoded tx in Bytes instead of RLPOutput Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: George Tebrean <99179176+gtebrean@users.noreply.github.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>

* added missing methods to transaction interface, created new AccessListEntry interface to add it to the transaction interface Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * CHANGELOG.md entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadoc entry Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Make smart contract permissioning features work with london fork (hyperledger#5727) * Make smart contract permissioning features work with london fork Override the transactionSimulator's default TransactionValidationParams with one that allows for exceeding the account balance (which effectively zeros the baseFee). This mimics the way that eth_estimateGas and eth_call are implemented. Similar change to hyperledger#5277 Update ATs to use londonBlock (existing genesis allocs necessitate zeroBaseFee as well) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * changelog Signed-off-by: Simon Dudley <simon.dudley@consensys.net> --------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Correctly cache the TransactionValidator instance on creation (hyperledger#5726) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Reference tests 12.3 (hyperledger#5733) Update Reference Tests to 12.3 * fix decoding error * add ignored field * update module Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Return all not selected transactions, not only invalid ones. (hyperledger#5711) This way it is possible for the caller to have more data about the selection process. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Address import performance issues (hyperledger#5734) * ensure we are on a single tuweni version * factor out an unneeded concatenate Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Add type to PendingTransactionDetail (hyperledger#5729) * add type * update changelog --------- Signed-off-by: George Tebrean <george@web3labs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Migrate to blobGas in execution-spec-tests (hyperledger#5745) Execution-spec-tests migrated from DataGas to BlobGas and checks for its inclusion in tests now. Add needed support. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * remove AccessListEntry interface and move its class to the datatypes module Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add missing cost methods to interface, add method to get RLP of transaction Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * updating hash with updated reference tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * added missing javadocs Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * fixed compiler errors in integration tests Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * retro blobGas name change into Transaction interface Signed-off-by: garyschulte <garyschulte@gmail.com> * removed methods from transaction interface which values can be derived through other means. Added new method encoded to return the encoded tx in Bytes instead of RLPOutput Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: George Tebrean <george@web3labs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: George Tebrean <99179176+gtebrean@users.noreply.github.com> Co-authored-by: garyschulte <garyschulte@gmail.com>

github-advanced-security bot found potential problems Jul 30, 2023

View reviewed changes

evm/src/main/java/org/hyperledger/besu/evm/AccessListEntry.java Fixed Show fixed Hide fixed

macfarla reviewed Jul 31, 2023

View reviewed changes

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Outdated Show resolved Hide resolved

datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java Outdated Show resolved Hide resolved

shemnon suggested changes Jul 31, 2023

View reviewed changes

datatypes/src/main/java/org/hyperledger/besu/datatypes/AccessListEntry.java Outdated Show resolved Hide resolved

daniellehrner and others added 14 commits August 4, 2023 16:41

added missing methods to transaction interface, created new AccessLis…

e3752c8

…tEntry interface to add it to the transaction interface Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

CHANGELOG.md entry

d4cdcc3

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added missing javadoc entry

e1e93dc

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transac…

547133b

…tion.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Update datatypes/src/main/java/org/hyperledger/besu/datatypes/Transac…

3ebafb3

…tion.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Correctly cache the TransactionValidator instance on creation (hyperl…

ff7c669

…edger#5726) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Reference tests 12.3 (hyperledger#5733)

d7c6ef3

Update Reference Tests to 12.3 * fix decoding error * add ignored field * update module Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Address import performance issues (hyperledger#5734)

bf99643

* ensure we are on a single tuweni version * factor out an unneeded concatenate Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Add type to PendingTransactionDetail (hyperledger#5729)

4f0fe20

* add type * update changelog --------- Signed-off-by: George Tebrean <george@web3labs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

remove AccessListEntry interface and move its class to the datatypes …

4e08e53

…module Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

add missing cost methods to interface, add method to get RLP of trans…

312769b

…action Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner force-pushed the feat/issue-5731/update-transaction-interface branch from e4094b8 to 312769b Compare August 4, 2023 14:41

daniellehrner added 4 commits August 4, 2023 16:47

Merge branch 'main' into feat/issue-5731/update-transaction-interface

8bf7073

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

updating hash with updated reference tests

5f6666d

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added missing javadocs

6855b76

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

fixed compiler errors in integration tests

5ca6a64

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner requested a review from shemnon August 8, 2023 22:01

Merge branch 'main' into feat/issue-5731/update-transaction-interface

180135a

garyschulte reviewed Aug 21, 2023

View reviewed changes

datatypes/src/main/java/org/hyperledger/besu/datatypes/AccessListEntry.java Show resolved Hide resolved

garyschulte approved these changes Aug 21, 2023

View reviewed changes

garyschulte added 2 commits August 21, 2023 14:45

Merge branch 'main' into feat/issue-5731/update-transaction-interface

876c4e4

Signed-off-by: garyschulte <garyschulte@gmail.com>

retro blobGas name change into Transaction interface

3d7c991

Signed-off-by: garyschulte <garyschulte@gmail.com>

shemnon reviewed Aug 21, 2023

View reviewed changes

daniellehrner added 2 commits August 22, 2023 14:58

removed methods from transaction interface which values can be derive…

b71032f

…d through other means. Added new method encoded to return the encoded tx in Bytes instead of RLPOutput Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Merge branch 'main' into feat/issue-5731/update-transaction-interface

12b88e1

daniellehrner requested a review from shemnon August 22, 2023 14:07

shemnon approved these changes Aug 22, 2023

View reviewed changes

daniellehrner merged commit 19c989a into hyperledger:main Aug 22, 2023
8 checks passed

daniellehrner deleted the feat/issue-5731/update-transaction-interface branch August 22, 2023 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing methods to transaction interface #5732

Add missing methods to transaction interface #5732

daniellehrner commented Jul 30, 2023

github-actions bot commented Jul 30, 2023 •

edited by daniellehrner

Loading

garyschulte left a comment

garyschulte commented Aug 21, 2023 •

edited

Loading

shemnon left a comment

shemnon Aug 21, 2023

daniellehrner Aug 22, 2023

shemnon Aug 22, 2023

daniellehrner commented Aug 22, 2023

shemnon left a comment

Add missing methods to transaction interface #5732

Add missing methods to transaction interface #5732

Conversation

daniellehrner commented Jul 30, 2023

PR description

Fixed Issue(s)

github-actions bot commented Jul 30, 2023 • edited by daniellehrner Loading

garyschulte left a comment

Choose a reason for hiding this comment

garyschulte commented Aug 21, 2023 • edited Loading

shemnon left a comment

Choose a reason for hiding this comment

shemnon Aug 21, 2023

Choose a reason for hiding this comment

daniellehrner Aug 22, 2023

Choose a reason for hiding this comment

shemnon Aug 22, 2023

Choose a reason for hiding this comment

daniellehrner commented Aug 22, 2023

shemnon left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 30, 2023 •

edited by daniellehrner

Loading

garyschulte commented Aug 21, 2023 •

edited

Loading