Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered txpool by default and txpool options hoverhaul #5772

Merged
merged 10 commits into from
Sep 11, 2023

Merge branch 'main' into txpool-impl-option

b4960f1
Select commit
Loading
Failed to load commit list.
Merged

Layered txpool by default and txpool options hoverhaul #5772

Merge branch 'main' into txpool-impl-option
b4960f1
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Sep 11, 2023 in 25s

3 new alerts

New alerts in code changed by this pull request

  • 3 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 1522 in ethereum/eth/build/generated/sources/annotationProcessor/java/main/org/hyperledger/besu/ethereum/eth/transactions/ImmutableTransactionPoolConfiguration.java

See this annotation in the file changed.

Code scanning / CodeQL

Class has same name as super class Note generated

Unstable has the same name as its supertype
org.hyperledger.besu.ethereum.eth.transactions.TransactionPoolConfiguration$Unstable
.

Check notice on line 123 in besu/src/main/java/org/hyperledger/besu/cli/options/OptionParser.java

See this annotation in the file changed.

Code scanning / CodeQL

Confusing overloading of methods Note

Method OptionParser.format(..) could be confused with overloaded method
format
, since dispatch depends on static types.
Method OptionParser.format(..) could be confused with overloaded method
format
, since dispatch depends on static types.

Check notice on line 61 in besu/src/main/java/org/hyperledger/besu/cli/options/OptionParser.java

See this annotation in the file changed.

Code scanning / CodeQL

Confusing overloading of methods Note

Method OptionParser.format(..) could be confused with overloaded method
format
, since dispatch depends on static types.