fix snapsync issue with forest #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
|
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
|
Tests done
|
fab-10
approved these changes
Aug 21, 2023
Comment on lines
82
to
84
| public Optional<Bytes> getUnSafeTrieNode(final Bytes key) { | ||
| return keyValueStorage.get(key.toArrayUnsafe()).map(Bytes::wrap); | ||
| } |
There was a problem hiding this comment.
a style suggestion, rename method to getTrieNodeUnsafe to uniform with other unsafe methods like toArrayUnsafe
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Aug 28, 2023
Fixing an issue during snapsync with forest related to the heal step Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Aug 28, 2023
Fixing an issue during snapsync with forest related to the heal step Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Aug 28, 2023
Fixing an issue during snapsync with forest related to the heal step Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Fixing an issue during snapsync with forest related to the heal step Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixing an issue during snapsync with forest related to the heal step
the step checking whether the node existed or not during the healing process could lead to a null pointer exception due to the null nodeHash, which was only utilized within the context of forest.
Fixed Issue(s)