Fix snapsync heal #5838

matkt · 2023-09-01T12:50:20Z

PR description

This PR improves the snapsync, particularly the healing stage.

It enhances the stability of the trie healing by avoiding the bug that causes the sync to get stuck at 99%.
It improves the tracking of invalid accounts to improve the healing of the flatDB.
It fix some issues related to the healing of the flat db.

We are also adding more comment and some cleaning of the code

TESTS

2 mainnet nodes (snapsync + snapsync with flat db heal)
2 goerli nodes (snapsync + snapsync with flat db heal)
6 sepolia nodes (snapsync + snapsync with flat db heal)

Fixed Issue(s)

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

github-actions · 2023-09-01T12:53:56Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt · 2023-09-11T15:09:41Z

...th/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/SnapWorldDownloadState.java

    }
  }

-  public HashSet<Bytes> getAccountsToBeRepaired() {
-    return accountsToBeRepaired;
+  public HashSet<Bytes> getAccountsHealingList() {


ignore this one because it's not in the scope of this PR. I'm just renaming the method in this PR . Don't want to modify the logic

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

macfarla

PR looks good @matkt - but I'm curious as to which change exactly fixed the 99% bug?

matkt · 2023-09-12T07:35:16Z

PR looks good @matkt - but I'm curious as to which change exactly fixed the 99% bug?

mainly related to https://github.com/hyperledger/besu/pull/5838/files#diff-e341896fe8d23fac861ef07ae0a8edd6d3412c4ffd356af6b53698507d62f1b9R116

This was related to accounts that were marked for healing at a later stage. The problem was that the storage for these accounts became empty in the meantime. As a result, we were trying to heal an empty storage and were asking the peer for the storage root node. Since the storage was empty, the peers returned an empty response, and we kept trying indefinitely because, from our perspective, we were waiting for a response.

garyschulte · 2023-09-12T22:38:28Z

...th/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/SnapWorldDownloadState.java

-          reloadTrieHeal();
-        }
+      final AtomicBoolean foundNewPivotBlock = new AtomicBoolean(false);
+      pivotBlockSelector.check(


is it not a problem that check executes async code when it determines that the pivot block is too far behind ? For example could we incorrectly return no new pivot if we have no peers.

The async code in DynamicPivotBlockSelector makes this hard to reason about. This PR doesn't make this worse, but still hard to follow.

Indeed, the code for the Pivot Block Selector is a bit complex to understand and could benefit from more detailed descriptions.

This class fetches pivot blocks in advance to avoid having to search at the time of the call. I don't have the exact numbers, but for example:

I call the check method and if the distance to the head is >60 and <126, I will cache a pivot block. I won't use it right now. On the next call, when the distance to the head is >126, I will take the one cached. This means that every time we call this method and we are in this range(>60 and <126), we are looking for a pivot block to put in a cache , This is to have fast access to the next pivot block

In conclusion, there will be no problem as it will be synchronous (every time we will take the pivot from cache).

it would probably be beneficial to simplify this pivot block selection code in the future as it's more technical debt. Previously, obtaining a pivot block required querying 5 peers and reaching a consensus, which could be time-consuming. Now, it's simply a matter of taking the last safe block. Therefore, this logic may no longer be necessary.

garyschulte · 2023-09-12T22:50:12Z

...ger/besu/ethereum/eth/sync/snapsync/request/heal/AccountFlatDatabaseHealingRangeRequest.java

+    Stream.of(existingAccounts.entrySet(), flatDbAccounts.entrySet())
        .flatMap(Collection::stream)


non blocking, but Streams.concat() would be more readable than Stream.of(..).flatMap(Collection::stream).

do you prefer something like that ?

Stream.concat(existingAccounts.entrySet().stream(), flatDbAccounts.entrySet().stream()) .forEach( ```

.../hyperledger/besu/ethereum/eth/sync/snapsync/request/heal/AccountTrieNodeHealingRequest.java

garyschulte

Generally LGTM. The comments are very helpful. It would be helpful to have a joint review though, to clear up some questions.

Also there seems to be a problem with the upstream version metadata, not related to the PR.

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

garyschulte

🚢

--- Drop Kotti Network support (ETC) (hyperledger#5816) Signed-off-by: Diego López León <dieguitoll@gmail.com> fix ForkId if there are no Forks and the starting timestamp is not 0 (hyperledger#5819) Signed-off-by: Stefan <stefan.pingel@consensys.net> enforce that BlobTransactions have at least one blob (hyperledger#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Do not create ignorable segments on `revert storage-variables` (hyperledger#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <garyschulte@gmail.com> add versioned hashes and number of blobs to toString() (hyperledger#5831) Signed-off-by: Stefan <stefan.pingel@consensys.net> add parent beacon block root to payload id calculation (hyperledger#5843) Signed-off-by: Stefan <stefan.pingel@consensys.net> bump version to 23.7.3-SNAPSHOT (hyperledger#5854) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> set the beacon root address to the correct value (hyperledger#5853) Signed-off-by: Stefan <stefan.pingel@consensys.net> docs(readme): fix broken link to installation of binaries page (hyperledger#5859) Fixes hyperledger#5858 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Update RocksDB version from 8.0.0 to 8.3.2 (hyperledger#5832) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> use non-deprecated authenticate methods (hyperledger#5852) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> move to Hyperledger shared runners for current github actions (hyperledger#5860) Signed-off-by: garyschulte <garyschulte@gmail.com> Add range tracing with worldstate (hyperledger#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Layered txpool by default and txpool options hoverhaul (hyperledger#5772) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (hyperledger#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> updated gradle verification metadata (hyperledger#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (hyperledger#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Stefan <stefan.pingel@consensys.net> payload attributes: fix wrong warning and fail if beacon root is available before cancun (hyperledger#5872) Signed-off-by: Stefan <stefan.pingel@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Merge MutableAccount and EVMAccount (hyperledger#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Add world context to transaction tracing API (hyperledger#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Rebase on main Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * added test Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Bonsai based reference test worldstate (hyperledger#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Don't start BFT mining coordinators until initial sync has completed (hyperledger#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix unit tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> display only peers ready for requets on ethstats (hyperledger#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * cast to int Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> [MINOR] test RLP used for encode/decode blob tx should contain to field (hyperledger#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Fix: correctly convert percentage options in TOML configuration file (hyperledger#5886) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> EIP7516 - Add BlobBaseFee opcode to Cancun EVM (hyperledger#5884) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Fix snapsync heal (hyperledger#5838) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Upgrade besu-native (hyperledger#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Tune G1GC to reduce Besu memory footprint (hyperledger#5879) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Add updated storage to evmtool json trace (hyperledger#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Update holesky with fixed extraData, genesis time, shanghaiTime (hyperledger#5890) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> [CHANGELOG] removed duplicated line (hyperledger#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

burn-in candidate for 23.7.3 from main sha 6dc10a9..eef40bd https://github.com/hyperledger/besu/compare/6dc10a9..eef40bd --- * Drop Kotti Network support (ETC) (#5816) Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * fix ForkId if there are no Forks and the starting timestamp is not 0 (#5819) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * enforce that BlobTransactions have at least one blob (#5826) * enforce that BlobTransactions have at least one blob Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Do not create ignorable segments on `revert storage-variables` (#5830) * fix the bug that creates the ignorable chain pruner segment, add rocks exception parsing to RocksDBColumnarKeyValueStorage subclasses * parse rocksdb error for unprintable column family id's Signed-off-by: garyschulte <garyschulte@gmail.com> * add versioned hashes and number of blobs to toString() (#5831) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * add parent beacon block root to payload id calculation (#5843) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * bump version to 23.7.3-SNAPSHOT (#5854) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * set the beacon root address to the correct value (#5853) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * docs(readme): fix broken link to installation of binaries page (#5859) Fixes #5858 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Update RocksDB version from 8.0.0 to 8.3.2 (#5832) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * use non-deprecated authenticate methods (#5852) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * move to Hyperledger shared runners for current github actions (#5860) Signed-off-by: garyschulte <garyschulte@gmail.com> * Add range tracing with worldstate (#5844) Implement a method to trace a range of blocks and have access to the worldstate before and after the tracing Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Layered txpool by default and txpool options hoverhaul (#5772) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions (#5857) Fix issue 5824 - Duplicate key errors in EthScheduler-Transactions Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * updated gradle verification metadata (#5870) * removed old artefacts [skip ci] * works with compileTestJava * restored metadata needed for codeQL and trusted-artifacts block for javadoc/sources Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * [4844] Add encodingContext to TransactionEncoder and TransactionDecoder (#5820) * Add decode type to TransactionDecoder * Refactoring TransactionDecoder * Invert methods order * Use Transaction encoder instead of writeTo * Move enter and leave list to inner method as pr suggestion * Size calculation should use opaque bytes instead of rlp --------- Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * #5868: fix beacon root address and modulus for devnet 9 (#5871) Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * payload attributes: fix wrong warning and fail if beacon root is available before cancun (#5872) Signed-off-by: Stefan <stefan.pingel@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Merge MutableAccount and EVMAccount (#5863) Merge MutableAccount and EVMAccount functionalities by removing EVMAccount, all calls to getMutable, and the WrappedEVMAccount that was wrapping non-EVMAccounts in a mutable fashion. Instead, use a MutableAccount in all cases an EVMAccount would have been used. This also tends to reduce a level of layering in many places. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Add world context to transaction tracing API (#5836) * Add world context to transaction tracing API Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Update changelog with PR ID Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add the Transaction to traceEndTransaction Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Rebase on main Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * Add receipt-linked information to the transaction tracer Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> * added test Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Bonsai based reference test worldstate (#5686) * create a bonsai based reference test worldstate -> getOrCreate in BonsaiWorldStateUpdateAccumulator - do not throw if we discover an empty account in a non-null BonsaiValue<Account> -> add curentStateRoot to t8n -> storageEntriesFrom and streamAccounts implemented in BonsaiWorldStateKeyValueStorage -> add endKey version of streamFromKey * bonsai fix for self-destruct and create2 at the same address and same block Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Don't start BFT mining coordinators until initial sync has completed (#5861) * Don't start BFT mining coordinators until initial sync has completed Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix unit tests Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix 'enable' logic Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * display only peers ready for requets on ethstats (#5880) * display only ready for requets peers in ethstats Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * cast to int Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * [MINOR] test RLP used for encode/decode blob tx should contain to field (#5883) * validate to field on encode/decode for blob tx Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * revert decode/encode checks - tis done later in tx validation Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix: correctly convert percentage options in TOML configuration file (#5886) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * EIP7516 - Add BlobBaseFee opcode to Cancun EVM (#5884) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * Fix snapsync heal (#5838) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Upgrade besu-native (#5893) Upgrade besu-native to 0.8.2 Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Tune G1GC to reduce Besu memory footprint (#5879) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * Add updated storage to evmtool json trace (#5892) Add the EIP-3155 "storage" option to the standard tracer, with the caveat only updated storage is logged. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * Update holesky with fixed extraData, genesis time, shanghaiTime (#5890) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * [CHANGELOG] removed duplicated line (#5904) * removed duplicated line [skip ci] Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * fixed spelling on Holesky Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> * add 23.7.2 release SHAs and bump to 23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-23.7.3-RC version Signed-off-by: garyschulte <garyschulte@gmail.com> --------- Signed-off-by: Diego López León <dieguitoll@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Franklin Delehelle <franklin.delehelle@odena.eu> Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Peter Somogyvari <petermetz@users.noreply.github.com> Co-authored-by: ahamlat <ameziane.hamlat@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: matkt <karim.t2am@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: delehef <franklin.delehelle@odena.eu> Co-authored-by: Matt Whitehead <matthew1001@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

fix heal

7809ec5

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt force-pushed the heal-fix branch from b76b696 to c4b836e Compare September 4, 2023 09:12

jframe mentioned this pull request Sep 5, 2023

Besu v23.7.1 does not synchronize with goerli #5837

Closed

matkt mentioned this pull request Sep 7, 2023

Fresh snap sync did not start worldstate heal #5549

Open

fix bugs and add tests

26f35a6

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt force-pushed the heal-fix branch from 66c3e76 to 26f35a6 Compare September 8, 2023 13:35

matkt added 2 commits September 8, 2023 15:42

remove useless logs

9ef4497

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Merge branch 'main' into heal-fix

de39eec

github-advanced-security bot found potential problems Sep 8, 2023

View reviewed changes

matkt added 2 commits September 8, 2023 17:02

fix tests and clean code

54b2e77

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Merge branch 'main' into heal-fix

ed3c586

matkt changed the title ~~fix flat db healing~~ Fix snapsync heal Sep 11, 2023

matkt marked this pull request as ready for review September 11, 2023 09:16

macfarla reviewed Sep 12, 2023

View reviewed changes

Merge branch 'main' into heal-fix

c19d464

garyschulte reviewed Sep 12, 2023

View reviewed changes

macfarla reviewed Sep 12, 2023

View reviewed changes

.../hyperledger/besu/ethereum/eth/sync/snapsync/request/heal/AccountTrieNodeHealingRequest.java Show resolved Hide resolved

garyschulte reviewed Sep 12, 2023

View reviewed changes

matkt added 4 commits September 13, 2023 08:28

Merge branch 'main' into heal-fix

4132242

fix after reviews

2cd8215

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Merge branch 'main' into heal-fix

e8ca734

Merge branch 'main' into heal-fix

3564ccb

garyschulte approved these changes Sep 14, 2023

View reviewed changes

Merge branch 'main' into heal-fix

c6609b2

matkt enabled auto-merge (squash) September 18, 2023 15:30

matkt merged commit 3e724a0 into hyperledger:main Sep 18, 2023
19 checks passed

siladu mentioned this pull request Sep 20, 2023

Burn in release of 23.7.3 from main (inclusive of sha eef40bd) #5905

Closed

garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 20, 2023

Fix snapsync heal (hyperledger#5838)

5efc914

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

garyschulte pushed a commit to garyschulte/besu that referenced this pull request Sep 20, 2023

Fix snapsync heal (hyperledger#5838)

cc2904d

Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>

siladu pushed a commit to siladu/besu that referenced this pull request Sep 20, 2023

Fix snapsync heal (hyperledger#5838)

86f9fc9

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

siladu pushed a commit to siladu/besu that referenced this pull request Sep 20, 2023

Fix snapsync heal (hyperledger#5838)

4ae70eb

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

matkt deleted the heal-fix branch September 22, 2023 09:37

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

Fix snapsync heal (hyperledger#5838)

0516a2b

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023

Fix snapsync heal (hyperledger#5838)

c8147a8

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix snapsync heal #5838

Fix snapsync heal #5838

matkt commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023

matkt Sep 11, 2023

macfarla left a comment

matkt commented Sep 12, 2023

garyschulte Sep 12, 2023 •

edited

Loading

matkt Sep 13, 2023 •

edited

Loading

matkt Sep 13, 2023 •

edited

Loading

garyschulte Sep 12, 2023

matkt Sep 13, 2023

garyschulte left a comment

garyschulte left a comment

		Stream.of(existingAccounts.entrySet(), flatDbAccounts.entrySet())
		.flatMap(Collection::stream)

Fix snapsync heal #5838

Fix snapsync heal #5838

Conversation

matkt commented Sep 1, 2023 • edited Loading

PR description

TESTS

Fixed Issue(s)

github-actions bot commented Sep 1, 2023

matkt Sep 11, 2023

Choose a reason for hiding this comment

macfarla left a comment

Choose a reason for hiding this comment

matkt commented Sep 12, 2023

garyschulte Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

matkt Sep 13, 2023 • edited Loading

Choose a reason for hiding this comment

matkt Sep 13, 2023 • edited Loading

Choose a reason for hiding this comment

garyschulte Sep 12, 2023

Choose a reason for hiding this comment

matkt Sep 13, 2023

Choose a reason for hiding this comment

garyschulte left a comment

Choose a reason for hiding this comment

garyschulte left a comment

Choose a reason for hiding this comment

matkt commented Sep 1, 2023 •

edited

Loading

garyschulte Sep 12, 2023 •

edited

Loading

matkt Sep 13, 2023 •

edited

Loading

matkt Sep 13, 2023 •

edited

Loading