Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonsai limit trie logs enabled true #6561

Closed

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 13, 2024

Swap default value for --Xbonsai-limit-trie-logs-enabled from false to true

Also added a fallback value for the option (otherwise specifying --Xbonsai-limit-trie-logs-enabled on the command line, without a value, has the opposite effect

builds on #6536

This option is not yet documented so no docs changes required.

Breaking change
The limit is now enabled by default. If you do not want the limit enabled, you need to explicitly set it to false
--Xbonsai-limit-trie-logs-enabled=false
However - the default is set to 512 which should work for most use cases.

fixes #6560

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added the ux label Feb 13, 2024
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…arla/besu into bonsai-limit-trie-logs-enabled-true
@macfarla macfarla marked this pull request as draft February 15, 2024 06:35
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla closed this May 29, 2024
@macfarla macfarla deleted the bonsai-limit-trie-logs-enabled-true branch July 16, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default for bonsai-limit-trie-logs-enabled=True
1 participant