Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] Use better savings estimate for x-trie-log prune #6577

Merged
merged 2 commits into from
Feb 15, 2024
Merged

[MINOR] Use better savings estimate for x-trie-log prune #6577

merged 2 commits into from
Feb 15, 2024

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Feb 15, 2024 •
edited
Loading

Following on from #6540, use total-sst-files-size + total-blob-file-size instead of estimate-live-data-size for x-trie-log prune estimate.

@siladu
Use better estimate for trie log column family size
d39a4bb 
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2024 •
edited by siladu
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

@siladu siladu changed the title Use better estimate for trie log column family size [MINOR] Use better savings estimate for x-trie-log prune Feb 15, 2024
gfukushima
gfukushima approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siladu
Use resolve for paths
7abb42b 
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu enabled auto-merge (squash) February 15, 2024 06:45
@siladu siladu merged commit 8be243f into hyperledger:main Feb 15, 2024
50 checks passed
@siladu siladu deleted the trie-log-prune-estimate branch February 15, 2024 19:20
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
@siladu @suraneti
Use better savings estimate for x-trie-log prune (hyperledger#6577)
967722d 
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siladu @gfukushima