Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend BesuConfiguration service #6584

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 16, 2024

PR description

This PR adds a method to BesuConfiguration service get the current minGasPrice, in order to implement that a little refactoring was necessary, since services needs to be instantiated very early during the startup, since they need to be visible during the registration of the plugins, but at that stage most configurations are not yet ready, so there is now a separation between the instantiation and the initialization that is done after when the configuration is ready, the initialization is performed before the plugins start, so service are

Fixed Issue(s)

Copy link

github-actions bot commented Feb 16, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review February 16, 2024 20:01
@fab-10 fab-10 enabled auto-merge (squash) February 19, 2024 09:52
@fab-10 fab-10 merged commit 1d2d037 into hyperledger:main Feb 19, 2024
55 checks passed
suraneti pushed a commit to suraneti/besu that referenced this pull request Feb 24, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants