[EIP-1559] Step 5 - Gas price and gas limit block header validation rules #660
Conversation
- hyperledger#430 - hyperledger#440 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> # Conflicts: # CHANGELOG.md
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
…r specified in EIP-1559 Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
| @@ -99,6 +99,10 @@ private boolean applyRules( | |||
| return parent; | |||
| } | |||
|
|
|||
| public void addRule(final AttachedBlockHeaderValidationRule<C> rule) { | |||
There was a problem hiding this comment.
This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created.
There was a problem hiding this comment.
We still need to delete this method.
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Show resolved
Hide resolved
| @@ -284,6 +294,8 @@ | |||
|
|
|||
| final BlockHeaderValidator<T> blockHeaderValidator = | |||
| blockHeaderValidatorBuilder.apply(difficultyCalculator); | |||
| additionalBlockHeaderValidationRules.forEach(blockHeaderValidator::addRule); | |||
There was a problem hiding this comment.
This will require a tiny bit of replumbing. We can have blockHeaderValidatorBuilder return the builder instead of the fully assembled blockHeaderValidator. Then we call addRule on the builder, then build and store.
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Actually i realized with your comment that both |
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
There was a problem hiding this comment.
Approved with reservations. The issue with how intertwined the difficulty calculator is with all of this feels like it's out of scope for this PR, I would like it fixed but not bad enough to block progress on 1559 work. I opened #687 so we can come back to it later. This PR adds some technical debt to some pre-existing debt, but I don't think we can pay it off before we get this prototype done.
PR description
Implement 2 new
AttachedBlockHeaderValidationRuleEIP1559BlockHeaderGasPriceValidationRuleEIP1559BlockHeaderGasLimitValidationRuleFixed Issue(s)
fixes #597 #598
Signed-off-by: Abdelhamid Bakhta abdelhamid.bakhta@consensys.net