Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gha updates #6705

Merged
merged 23 commits into from
Mar 12, 2024
Merged

Gha updates #6705

merged 23 commits into from
Mar 12, 2024

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Mar 8, 2024 •
edited
Loading

PR description

Fixed Issue(s)

fixes #6695

  • No longer defers testing till after approval, functionality to be redesigned
  • concurrent runs for the same branch will be cancelled on update to the ref
  • new develop floating pre-release to be maintained with downloadable artifacts on push to main
  • codeql job deferred to nightly runs on main

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

macfarla
macfarla approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of q's

.github/workflows/codeql.yml Show resolved Hide resolved
.github/workflows/develop.yml Show resolved Hide resolved
.github/workflows/develop.yml
- name: upload tarball
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3
with:
path: 'build/distributions/besu*.tar.gz'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need the girhub.ref_name in the path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, that will always be main so we can replace that with something static.

jflo added 22 commits March 12, 2024 15:51
@jflo
sets metaspace explicitly after gradle reset a la gradle/gradle#19750
da3fda7 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
allow manual runs of accept-test workflow
06d2524 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
don't try to get prs that don't exist
f8f96e1 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
make artifacts more snapshot friendly
86aad28 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
not javascript on those
64a63ca 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
something on the windows runner changed
f0f8c93 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
debugging stupid windows
9c53a6b 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
guess its powershell
976745f 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
avoid subdirs
14c6c91 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
break out new workflows for snapshots, and a develop releease
c9b5bee 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
develop should be all we need
e436e9f 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
only on main
28079b1 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
removes checking for approval, runs on pr update
8e10c1a 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
docker might need manual run
854327e 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
fixes job dependencies
1849833 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
adds concurrency so updated refs cancel prior runs if still running
b366775 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
explicitly disable caching on gradle setup tasks
5d1b3ae 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
run codeql on main at midnight, collect gradle args into env
dc99d69 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
use env to require approval before pushing to dockerhub
0f89676 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
typo in branch match
ce662f0 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
deployment environment approvals do not seem to work as designed
ac2affc 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
disable gradle caching to debug errorprone
8a946cb 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo
static filename
0f9d145 
Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
macfarla approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jflo jflo enabled auto-merge (squash) March 12, 2024 22:06
@jflo jflo merged commit 934e435 into hyperledger:main Mar 12, 2024
45 checks passed
@siladu
Copy link
Contributor

siladu commented Mar 13, 2024

@jflo develop workflow looks great, thanks! 👍

MASDXI pushed a commit to MASDXI/besu that referenced this pull request Mar 13, 2024
@jflo @MASDXI
Gha updates (hyperledger#6705)
ee9eb03 
* make artifacts more snapshot friendly
* break out new workflows for snapshots, and a develop releease
* removes checking for approval, runs on pr update
* adds concurrency so updated refs cancel prior runs if still running
* explicitly disable caching on gradle setup tasks
---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: MASDXI <sirawitt42@gmail.com>
siladu added a commit that referenced this pull request Apr 11, 2024
@siladu
Attempt to fix permissions and gradle issue for publish and publishAr…
55cdb23 
…tifactory

Relates to changes from #6705
and 5ea9cd6
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu mentioned this pull request Apr 11, 2024
Merged
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@jflo @amsmota
Gha updates (hyperledger#6705)
67bb317 
* make artifacts more snapshot friendly
* break out new workflows for snapshots, and a develop releease
* removes checking for approval, runs on pr update
* adds concurrency so updated refs cancel prior runs if still running
* explicitly disable caching on gradle setup tasks
---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
@jflo @amsmota
Gha updates (hyperledger#6705)
1512b8b 
* make artifacts more snapshot friendly
* break out new workflows for snapshots, and a develop releease
* removes checking for approval, runs on pr update
* adds concurrency so updated refs cancel prior runs if still running
* explicitly disable caching on gradle setup tasks
---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@jflo @matthew1001
Gha updates (hyperledger#6705)
b2fddf6 
* make artifacts more snapshot friendly
* break out new workflows for snapshots, and a develop releease
* removes checking for approval, runs on pr update
* adds concurrency so updated refs cancel prior runs if still running
* explicitly disable caching on gradle setup tasks
---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/CD improvements
3 participants
@jflo @siladu @macfarla