-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7002: Add exits/exits_root to block/block_header #6801
Conversation
…tion payload for engineV4 methods Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a first look. Looking good. I have added some comments.
Also, maybe two test similar to
shouldReturnValidIfDepositsIsNotNull_WhenDepositsAllowed
and shouldReturnInvalidIfDepositsIsNotNull_WhenDepositsProhibited
would be nice
...va/org/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/EnginePayloadParameter.java
Outdated
Show resolved
Hide resolved
...main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/BlockResultFactory.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Block.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Block.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/BlockHeaderBuilder.java
Outdated
Show resolved
Hide resolved
...eum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/ValidatorExitDecoder.java
Outdated
Show resolved
Hide resolved
...eum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/ValidatorExitEncoder.java
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ValidatorExitsValidator.java
Show resolved
Hide resolved
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
PR description
engine_newPayloadV4
andengine_getPayloadV4
for exitsFixed Issue(s)
related to #6800