Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web3j dependencies #6811

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 26, 2024

PR description

Compilation is failing due some web3j artifacts not available anymore, so just updating them to latest verison

A problem occurred configuring project ':acceptance-tests:tests'.
> Could not resolve all files for configuration ':acceptance-tests:tests:classpath'.
   > Could not resolve org.web3j:web3j-gradle-plugin:4.9.2.
     Required by:
         project :acceptance-tests:tests > org.web3j:org.web3j.gradle.plugin:4.9.2
      > Skipped due to earlier error
   > Could not resolve org.web3j.solidity:solidity-gradle-plugin:0.3.5.
     Required by:
         project :acceptance-tests:tests > org.web3j.solidity:org.web3j.solidity.gradle.plugin:0.3.5
      > Skipped due to earlier error

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@@ -17,6 +17,10 @@
pluginManagement {
repositories {
gradlePluginPortal()
maven {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? There are no plugins from the tech.pegasys namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed because new web3j plugin has tech.pegasys:jc-kzg-4844 as dependency

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not good. Web3j cannot be loaded entirely from maven central? Consensys should invest time in getting these published to Maven Central.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know someone is already working on that, so this will not be required in a future version, in the meantime what you prefer, using version 4.10.0 of the plugin or temporarily keeping the extra repo here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have the repository in our general listings. I was hoping we could keep the plugins section minimal. So this is acceptable since a long term solution is progressing.

@fab-10 fab-10 marked this pull request as ready for review March 26, 2024 19:22
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) April 2, 2024 14:20
@fab-10 fab-10 merged commit cf5e3da into hyperledger:main Apr 2, 2024
42 checks passed
@fab-10 fab-10 deleted the update-web3j-dependencies branch April 2, 2024 15:07
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* Update Web3j dependencies

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Force old version of the solidity compiler to pass AT

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* Update Web3j dependencies

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Force old version of the solidity compiler to pass AT

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* Update Web3j dependencies

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Force old version of the solidity compiler to pass AT

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 7, 2024
* Update Web3j dependencies

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

* Force old version of the solidity compiler to pass AT

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

---------

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants