Improve logging of peer disconnects due to subprotocol triggered #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…entioned as a reason elsewhere in the code Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
changed the title
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…e/besu into peer_subprotocol_triggered_logging
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…on (hyperledger#6886) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…on (hyperledger#6886) Signed-off-by: Jason Frame <jason.frame@consensys.net> Signed-off-by: amsmota <antonio.mota@citi.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Apr 26, 2024
…on (hyperledger#6886) Signed-off-by: Jason Frame <jason.frame@consensys.net>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…on (hyperledger#6886) Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add additional detail when we disconnect with SUBPROTOCOL_TRIGGERED disconnect reason. I've extended the enum with additional SUBPROTOCOL_TRIGGERED values using the same code
0x10and added a message to these extendedSUBPROTOCOL_TRIGGEREDreasons.If we receive a
0x10this is mapped back to the genericSUBPROTOCOL_TRIGGEREDreason.example with the changes
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests